Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve minimap design and position in new canvas (no-changelog) #10429

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

alexgrozav
Copy link
Contributor

Summary

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7568/improve-minimap-design-and-behaviour

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Aug 15, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 15, 2024
Copy link
Member

@elsmr elsmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As an aside, I'm not sure if there is an issue for this already, but we need to improve minimap and controls styling in dark mode:

image

Copy link

cypress bot commented Aug 15, 2024



Test summary

401 0 0 0Flakiness 1


Run details

Project n8n
Status Passed
Commit 6156ab0
Started Aug 15, 2024 9:55 AM
Ended Aug 15, 2024 10:00 AM
Duration 04:48 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


Flakiness

e2e/17-sharing.cy.ts Flakiness
1 Sharing > credentials should work between team and personal projects

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 469896a into master Aug 15, 2024
27 checks passed
@alexgrozav alexgrozav deleted the n8n-7568-improve-minimap-design-and-behaviour branch August 15, 2024 10:18
MiloradFilipovic added a commit that referenced this pull request Aug 16, 2024
* master:
  fix(Google Sheets Node): Update name and hint for useAppend option (#10443)
  fix(editor): Show item count in output panel schema view (#10426)
  ci: Introduce lint rule `no-untyped-config-class-field` (no-changelog) (#10436)
  fix(editor): Highlight matching type in filter component (#10425)
  feat(Facebook Graph API Node): Update node to support API v18 - v20 (#10419)
  fix(editor): Truncate long data pill labels in schema view (#10427)
  fix(core): Use explicit types in configs to ensure valid decorator metadata (#10433)
  fix(n8n Form Trigger Node): Show basic authentication modal on wrong credentials (#10423)
  fix(editor): Remove item count from pinned data status icon in new canvas (no-changelog) (#10431)
  feat(editor): Improve node selection outline in new canvas (no-changelog) (#10430)
  feat: Improve minimap design and position in new canvas (no-changelog) (#10429)
@janober
Copy link
Member

janober commented Aug 21, 2024

Got released with n8n@1.56.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants