Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Switch to MJML for email templates #10518
feat(core): Switch to MJML for email templates #10518
Changes from 1 commit
60104fb
78f1f2f
c4e021d
5499dcc
b3c9362
bf2333e
5d24a01
062c67a
7c81fb2
c4a9376
928db25
afee928
6e2089a
f58a2ad
9da8536
b3114bf
e4f415b
262eb47
5b30cc8
4425309
bbb2bc2
a8c6d98
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra sentence/link somewhere explaining to the invitee what even is n8n?
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not familiar with MJML, maybe there's a way to extract common styles to
_common
and use CSS classes instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while it is possible, I've always struggled it do that in the past. Also, since these are emails, all those styles are likely to be inlined anyways.
I'd like to improve this whole setup, but perhaps in another PR.