fix(Wait Node): Prevent waiting until invalid date

packages/core/src/NodeExecuteFunctions.ts

@@ -160,6 +160,7 @@ import { InstanceSettings } from './InstanceSettings';
 import { ScheduledTaskManager } from './ScheduledTaskManager';
 import { SSHClientsManager } from './SSHClientsManager';
 import { binaryToBuffer } from './BinaryData/utils';
+import { assertValidDate } from './assertions';
 
 axios.defaults.timeout = 300000;
 // Prevent axios from adding x-form-www-urlencoded headers by default
@@ -3776,7 +3777,9 @@ export function getExecuteFunctions(
 				);
 				return dataProxy.getDataProxy();
 			},
-			async putExecutionToWait(waitTill: Date): Promise<void> {
+			async putExecutionToWait(waitTill: unknown): Promise<void> {
+				assertValidDate(waitTill);
+
 				runExecutionData.waitTill = waitTill;
 				if (additionalData.setExecutionStatus) {
 					additionalData.setExecutionStatus('waiting');

packages/core/src/assertions.ts

@@ -0,0 +1,7 @@
+import { ApplicationError } from 'n8n-workflow';
+
+export function assertValidDate(candidate: unknown): asserts candidate is Date {
+	if (!(candidate instanceof Date) || isNaN(candidate.getTime())) {
+		throw new ApplicationError('Found invalid date', { extra: { date: candidate } });
+	}
+}

packages/core/test/assertions.test.ts

@@ -0,0 +1,22 @@
+import { assertValidDate } from '@/assertions';
+import { ApplicationError } from 'n8n-workflow';
+
+describe('assertions', () => {
+	describe('assertValidDate', () => {
+		it('should throw if the candidate is not a date', () => {
+			expect(() => assertValidDate(null)).toThrowError(
+				new ApplicationError('Found invalid date', { extra: { date: null } }),
+			);
+		});
+
+		it('should throw if the candidate is an invalid date', () => {
+			expect(() => assertValidDate(new Date('invalid'))).toThrowError(
+				new ApplicationError('Found invalid date', { extra: { date: new Date('invalid') } }),
+			);
+		});
+
+		it('should not throw if the candidate is a valid date', () => {
+			expect(() => assertValidDate(new Date())).not.toThrow();
+		});
+	});
+});

packages/nodes-base/nodes/Wait/Wait.node.ts

@@ -7,7 +7,7 @@
 	IDisplayOptions,
 	IWebhookFunctions,
 } from 'n8n-workflow';
 import { WAIT_TIME_UNLIMITED } from 'n8n-workflow';
 
 import {
 	authenticationProperty,
@@ -31,6 +31,7 @@
 import { formWebhook } from '../Form/utils';
 import { updateDisplayOptions } from '../../utils/utilities';
 import { Webhook } from '../Webhook/Webhook.node';
+import { NodeOperationError } from 'n8n-workflow';
 
 const toWaitAmount: INodeProperties = {
 	displayName: 'Wait Amount',
@@ -346,6 +347,7 @@
 				},
 				default: '',
 				description: 'The date and time to wait for before continuing',
+				required: true,
 			},
 
 			// ----------------------------------
@@ -492,6 +494,13 @@
 		} else {
 			const dateTimeStr = context.getNodeParameter('dateTime', 0) as string;
 
+			if (dateTimeStr === '') {
+				throw new NodeOperationError(
+					context.getNode(),
+					'[Wait node] Cannot put execution to wait because `dateTime` parameter is empty. Please pick a specific date and time to wait until.',
+				);
+			}
+
 			waitTill = DateTime.fromFormat(dateTimeStr, "yyyy-MM-dd'T'HH:mm:ss", {
 				zone: context.getTimezone(),
 			})