refactor(core): Convert verbose to debug logs
#10574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
commented
Aug 27, 2024
| @@ -40,7 +40,7 @@ export class WorkflowStatisticsController { | |||
| if (workflow) { | |||
| next(); | |||
| } else { | |||
| this.logger.verbose('User attempted to read a workflow without permissions', { | |||
| this.logger.warn('User attempted to read a workflow without permissions', { | |||
There was a problem hiding this comment.
In a few cases it seemed appropriate to bump them up even higher.
tomi
approved these changes
Aug 28, 2024
Comment on lines
-118
to
-121
|
|
||
| verbose(message: string, meta: object = {}): void { | ||
| this.log('verbose', message, meta); | ||
| } |
| @@ -90,7 +90,7 @@ export class WorkflowStatisticsService extends TypedEmitter<WorkflowStatisticsEv | |||
| } | |||
| } | |||
| } catch (error) { | |||
| this.logger.verbose('Unable to fire first workflow success telemetry event'); | |||
| this.logger.debug('Unable to fire first workflow success telemetry event'); | |||
There was a problem hiding this comment.
Shouldn't we fire a sentry alert in cases like these? Nobody probably ever notices if the code ends up here and this might be hiding a bug. Not saying it should be done in this PR, but not delighted by this type of pattern
There was a problem hiding this comment.
Agree, the workflow statistics service needs a lot of work. Let's do a follow-up.
| @@ -362,7 +362,7 @@ export class WorkflowsController { | |||
|
|
|||
| const workflow = await this.workflowService.delete(req.user, workflowId); | |||
| if (!workflow) { | |||
| this.logger.verbose('User attempted to delete a workflow without permissions', { | |||
| this.logger.warn('User attempted to delete a workflow without permissions', { | |||
| workflowId, | |||
| userId: req.user.id, | |||
| }); | |||
There was a problem hiding this comment.
Side note: The error should be ForbiddenError and not BadRequestError. No need to fix now, just pointing out
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
verbose-to-debug-logs
|
| Run status |
|
| Run duration | 04m 37s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
421
|
| View all changes introduced in this branch ↗︎ | |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 28, 2024
* master: ci: Fix provenance generation during NPM publish (no-changelog) (#10586) feat(core): Expose queue metrics for Prometheus (#10559) refactor(core): Map out pubsub messages (no-changelog) (#10566) fix: Fix scenario prefix not being passed (no-changelog) (#10575) refactor(core): Convert `verbose` to `debug` logs (#10574)
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 28, 2024
* master: (24 commits) feat(core): Switch to MJML for email templates (#10518) fix(Gmail Trigger Node): Don't return date instances, but date strings instead (#10582) fix(core): Deduplicate sentry events using error stacktraces instead (no-changelog) (#10590) feat(editor): Implement new app layout (#10548) refactor(core): Standardize filename casing for services and Public API (no-changelog) (#10579) 🚀 Release 1.57.0 (#10587) fix(editor): Add tooltips to workflow history button (#10570) ci: Fix provenance generation during NPM publish (no-changelog) (#10586) feat(core): Expose queue metrics for Prometheus (#10559) refactor(core): Map out pubsub messages (no-changelog) (#10566) fix: Fix scenario prefix not being passed (no-changelog) (#10575) refactor(core): Convert `verbose` to `debug` logs (#10574) refactor(core): Use `@/databases/` instead of `@db/` (no-changelog) (#10573) ci: Fix destroy benchmark env workflow (no-changelog) (#10572) feat: Add benchmarking of pooled sqlite (no-changelog) (#10550) refactor(editor): User journey link to n8n.io (#10331) fix(Wait Node): Prevent waiting until invalid date (#10523) refactor(core): Standardize filename casing for controllers and databases (no-changelog) (#10564) refactor(core): Allow custom types on getCredentials (no-changelog) (#10567) fix(editor): Scale output item selector input width with value (#10555) ... # Conflicts: # packages/editor-ui/src/stores/assistant.store.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here and here.