Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add queue mode setup to benchmarks (no-changelog) #10608

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Aug 29, 2024

Built on top of #10589

Summary

Built on top of #10589

Add queue mode setup

Related Linear tickets, Github issues, and Community forum posts

CAT-69

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@tomi tomi changed the title feat(benchmark): Add queue mode setup (no-changelog) feat: Add queue mode setup (no-changelog) Aug 29, 2024
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Aug 29, 2024
csuermann
csuermann previously approved these changes Aug 29, 2024
Copy link

cypress bot commented Aug 29, 2024

n8n    Run #6680

Run Properties:  status check passed Passed #6680  •  git commit bcdddcda7b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project n8n
Branch Review cat-69-add-queue-mode-setup
Run status status check passed Passed #6680
Run duration 04m 46s
Commit git commit bcdddcda7b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Committer Tomi Turtiainen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 421
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Base automatically changed from add-local-orchestration-of-benchmarks to master August 30, 2024 05:46
@tomi tomi dismissed csuermann’s stale review August 30, 2024 05:46

The base branch was changed.

@tomi tomi force-pushed the cat-69-add-queue-mode-setup branch from 12be56b to bcdddcd Compare August 30, 2024 05:48
@tomi tomi changed the title feat: Add queue mode setup (no-changelog) feat: Add queue mode setup to benchmarks (no-changelog) Aug 30, 2024
@tomi tomi requested a review from csuermann August 30, 2024 06:25
Copy link
Contributor

✅ All Cypress E2E specs passed

@tomi tomi merged commit 7e9d186 into master Aug 30, 2024
33 checks passed
@tomi tomi deleted the cat-69-add-queue-mode-setup branch August 30, 2024 06:42
MiloradFilipovic added a commit that referenced this pull request Aug 30, 2024
* master: (21 commits)
  feat: Add queue mode setup to benchmarks (no-changelog) (#10608)
  feat: Add n8n postgres setup to benchmarks (no-changelog) (#10604)
  fix(API): Update express-openapi-validator to resolve AIKIDO-2024-10229 (#10612)
  fix: Fix edge case in log in (no-changelog) (#10610)
  feat: Add local orchestration of benchmarks (no-changelog) (#10589)
  ci: Run nightly benchmark against nightly n8n image (no-changelog) (#10588)
  fix: Reduce variability in benchmarks (no-changelog) (#10606)
  docs: Add missing changelog entry (#10609)
  refactor(editor): Convert ResourceLocator to composition API (no-changelog) (#10526)
  feat(editor): Update new canvas node handle label rendering mechanism and design (no-changelog) (#10611)
  refactor(editor): Convert credential related components to composition API (no-changelog) (#10530)
  fix(HTTP Request Node): Sanitize authorization headers (#10607)
  refactor: Use `NodeConnectionType` consistently across the code base (no-changelog) (#10595)
  fix(editor): Hide execution buttons in readonly mode in new canvas (no-changelog) (#10603)
  fix(editor): Prevent keyboard shortcuts when ndv is open in new canvas (no-changelog) (#10601)
  fix(editor): Add confirmation toast when changing user role (#10592)
  feat(editor): Add support for changing sticky notes color in new canvas (no-changelog) (#10593)
  ci: Fix `forceConsistentCasingInFileNames` for aliased paths (no-changelog) (#10598)
  feat(editor): Allow sticky notes alongside fallback nodes in new canvas (no-changelog) (#10583)
  ci: Push nightly images to ghcr (no-changelog) (#10580)
  ...
@janober
Copy link
Member

janober commented Sep 5, 2024

Got released with n8n@1.58.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants