fix(core): Prevent backend from loading duplicate copies of nodes packages #10979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
elsmr
approved these changes
Sep 26, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
prevent-nodes-package-second-copies
|
| Run status |
|
| Run duration | 04m 22s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
433
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
|
Got released with |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now it's possible for someone to install
n8n-nodes-baseor@n8n/n8n-nodes-langchainas a community nodes, which starts messing up the n8n instance after they upgrade n8n, but older version of these packages are still around and being loaded into the app.This PR
PackageDirectoryLoaderto read the package name in the constructor, so thatloader.packageNameis available before we load any nodes/modulesLoadNodesAndCredentialsto never load a package if a loader for the same package name is already in memory.Related Linear tickets, Github issues, and Community forum posts
https://community.n8n.io/t/webhook-errors-after-updating/55083
Review / Merge checklist