-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Support node-creator actions for vector store nodes #11032
Merged
OlegIvaniv
merged 3 commits into
master
from
ai-253-add-action-submenu-for-hybrid-nodes-like-vector-stores
Oct 1, 2024
Merged
feat(editor): Support node-creator actions for vector store nodes #11032
OlegIvaniv
merged 3 commits into
master
from
ai-253-add-action-submenu-for-hybrid-nodes-like-vector-stores
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Oct 1, 2024
jeanpaul
previously approved these changes
Oct 1, 2024
n8n Run #7109
Run Properties:
|
Project |
n8n
|
Branch Review |
ai-253-add-action-submenu-for-hybrid-nodes-like-vector-stores
|
Run status |
Passed #7109
|
Run duration | 04m 05s |
Commit |
3ae319ab68: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
|
Committer | Oleg Ivaniv |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
437
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
OlegIvaniv
force-pushed
the
ai-253-add-action-submenu-for-hybrid-nodes-like-vector-stores
branch
from
October 1, 2024 11:49
042701c
to
3ae319a
Compare
jeanpaul
approved these changes
Oct 1, 2024
✅ All Cypress E2E specs passed |
OlegIvaniv
deleted the
ai-253-add-action-submenu-for-hybrid-nodes-like-vector-stores
branch
October 1, 2024 12:10
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements support for vector stores node creator actions. To generate the actions, we parse & collect all
mode
options. The actions should only be available when searching in node creator and not when adding a sub-node via the parent node.CleanShot.2024-10-01.at.09.15.48.mp4
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)