Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Support node-creator actions for vector store nodes #11032

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Oct 1, 2024

Summary

This PR implements support for vector stores node creator actions. To generate the actions, we parse & collect all mode options. The actions should only be available when searching in node creator and not when adding a sub-node via the parent node.

CleanShot.2024-10-01.at.09.15.48.mp4

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 1, 2024
jeanpaul
jeanpaul previously approved these changes Oct 1, 2024
Copy link

cypress bot commented Oct 1, 2024

n8n    Run #7109

Run Properties:  status check passed Passed #7109  •  git commit 3ae319ab68: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project n8n
Branch Review ai-253-add-action-submenu-for-hybrid-nodes-like-vector-stores
Run status status check passed Passed #7109
Run duration 04m 05s
Commit git commit 3ae319ab68: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Committer Oleg Ivaniv
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 437
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv force-pushed the ai-253-add-action-submenu-for-hybrid-nodes-like-vector-stores branch from 042701c to 3ae319a Compare October 1, 2024 11:49
Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit 72b70d9 into master Oct 1, 2024
33 checks passed
@OlegIvaniv OlegIvaniv deleted the ai-253-add-action-submenu-for-hybrid-nodes-like-vector-stores branch October 1, 2024 12:10
This was referenced Oct 2, 2024
@janober
Copy link
Member

janober commented Oct 2, 2024

Got released with n8n@1.62.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants