refactor(core): Simplify webhook pubsub message handler #11048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
despairblue
approved these changes
Oct 2, 2024
Comment on lines
+115
to
+119
| const subscriber = Container.get(Subscriber); | ||
| await subscriber.subscribe('n8n.commands'); | ||
| subscriber.setCommandMessageHandler(); | ||
|
|
||
| Container.get(PubSubHandler).init(); |
There was a problem hiding this comment.
Suggested change
| const subscriber = Container.get(Subscriber); | |
| await subscriber.subscribe('n8n.commands'); | |
| subscriber.setCommandMessageHandler(); | |
| Container.get(PubSubHandler).init(); | |
| Container.get(PubSubHandler).init(); | |
| const subscriber = Container.get(Subscriber); | |
| subscriber.setCommandMessageHandler(); | |
| await subscriber.subscribe('n8n.commands'); |
Would this order also work and prevent use form missing messages?
There was a problem hiding this comment.
Thanks! It's a tiny window - I'll address in the next PR 👍🏻
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
simplify-webhook-pubsub-msg-handler
|
| Run status |
|
| Run duration | 04m 27s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
437
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
|
Got released with |
1 similar comment
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplfy pubsub message handling in a
webhookprocess using typed event emitter, add tests, and deletehandleCommandMessageWebhookandOrchestrationHandlerWebhookService.https://linear.app/n8n/issue/PAY-2023
Ref: #10566