fix(Postgres Node): Special datetime values cause errors #11225
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Postgres Node uses the pg module to parse the postgres query response. However, this would fail for some special datetime values in postgres, e.g.
infinity
, and throw an error"Invalid time value"
.This PR adds a check to catch these and return them unparsed.
Since the modified parse function is only for
TIMESTAMP
orTIMESTAMPTZ
values, the only other possible edge case would benull
, which is returned correctly. The test table covers that.To Test:
Related Linear tickets, Github issues, and Community forum posts
Invalid time value
error if timestamp column contains special datetime values #8912Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)