refactor(core): Move queueModeId as hostId to InstanceSettings
#11262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
requested changes
Oct 15, 2024
valya
previously approved these changes
Oct 15, 2024
n8n
|
||||||||||||||||||||||||
| Project |
n8n
|
| Run status |
|
| Run duration | 04m 25s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
438
|
|
✅ All Cypress E2E specs passed |
netroy
reviewed
Oct 15, 2024
packages/cli/src/services/orchestration/main/multi-main-setup.ee.ts
Outdated
Show resolved
Hide resolved
| * @example 'worker-nDJR0FnSd2Vf6DB5' | ||
| * @example 'webhook-jxQ7AO8IzxEtfW1F' | ||
| */ | ||
| readonly hostId: string; |
There was a problem hiding this comment.
should we setup member-ordering linting rule to have consistent placement of properties in classes across the code?
There was a problem hiding this comment.
I've always found this rule unnecessarily restrictive. I find it more important to be able to group fields and methods semantically rather than alphabetically.
netroy
approved these changes
Oct 15, 2024
|
✅ All Cypress E2E specs passed |
ivov
deleted the
pay-2027-move-queuemodeid-as-hostid-to-instancesettings
branch
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/PAY-2027