refactor: Move OpenAI Base URL option to credentials #12175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
n8n-assistant
bot
added
n8n team
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Joffcom
reviewed
Dec 12, 2024
packages/@n8n/nodes-langchain/nodes/embeddings/EmbeddingsOpenAI/EmbeddingsOpenAi.node.ts
Outdated
Show resolved
Hide resolved
OlegIvaniv
approved these changes
Dec 16, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ado-2887-n8n-nodes-move-openai-base-url-option-to-credentials
|
| Run status |
|
| Run duration | 04m 41s |
| Commit |
|
| Committer | Ricardo Espinoza |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
480
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
RicardoE105
deleted the
ado-2887-n8n-nodes-move-openai-base-url-option-to-credentials
branch
|
Got released with |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prep work to be able to offer free AI credits and also harmonization as we usually have Base URLs in the credentials and not in the node itself.
Removes the Base URL parameters from the OpenAI nodes and uses the new Base URL parameters in the OpenAI credentials. I added versioning so this change should only affect the new version and keep "old" nodes using the Base URL from the node parameters working.
Only downside it's that we won't be able to show the
noticehere, since there is no way to reference a value from credentials in the displayOptions. Right?Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-2887/[n8n-nodes]-move-openai-base-url-option-to-credentials
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)