Add Deal description to Hubspot node #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks a lot. But did you test it? Because for me it looks like that it can not work as the field you did does never get used anywhere in the code. |
|
Looks like i forgot to include that file 🤦♂️, I went ahead and added it. |
|
Thanks a lot. I just tested. It looks like the Description for the update was in the node-code but the parameter was missing. Added it and then merged. Will be released with the next version. |
|
Got released with n8n@0.111.0 |
This was referenced Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the field "Deal description" to the Hubspot node for deals. Let me know if there's anything else needed to be done.