Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JSONata node #2556

Closed
wants to merge 3 commits into from
Closed

add JSONata node #2556

wants to merge 3 commits into from

Conversation

lublak
Copy link
Contributor

@lublak lublak commented Dec 13, 2021

No description provided.

@Joffcom
Copy link
Member

Joffcom commented Dec 13, 2021

"dist/nodes/JSONata/JSONata.node.js", is missing from package.json > nodes array.

@lublak
Copy link
Contributor Author

lublak commented Dec 13, 2021

@Joffcom thank you :) I will test everything later. I have extracted it from an old self-developed node.
There I have probably not paid proper attention.

@Joffcom
Copy link
Member

Joffcom commented Dec 13, 2021

@lublak It is all good, I am sure someone from n8n will give it a review later. Thought I would highlight the 2 changes I had to make to get it running.

@lublak
Copy link
Contributor Author

lublak commented Dec 14, 2021

@Joffcom I am also very grateful because I did not get to test yesterday :)
But I tested it earlier and with your two changes it should run completely.

@ivov ivov added node/new Creation of an entirely new node community Authored by a community member labels Dec 15, 2021
@Joffcom
Copy link
Member

Joffcom commented Sep 8, 2022

Hey @lublak,

Thanks for the contribution, We have now created a Community Node Repository which is our preferred method for new node submissions.

Once a node has been published to the Community Node Repository users will be able to install the node from their n8n interface and will be able to use your node quicker, You will also be able to update the node as needed without needing to wait for the review process.

In the future we may reach out to you about including your node in our main release, But for now I am going to close this PR.

You can find more information in the links below, If you have any questions about this or need any help let us know.

Building Community Nodes: https://docs.n8n.io/integrations/community-nodes/build-community-nodes/
Submitting Community Nodes: https://docs.n8n.io/integrations/creating-nodes/deploy/submit-community-nodes/
Published Nodes: https://www.npmjs.com/search?q=keywords:n8n-community-node-package

@Joffcom Joffcom closed this Sep 8, 2022
@lublak
Copy link
Contributor Author

lublak commented Sep 8, 2022

@Joffcom copy pasta! :P But yes I move it to a community node.

@cellerich
Copy link

@Joffcom copy pasta! :P But yes I move it to a community node.

@lublak what happened to the community node with jsonata? did you come around to implement it? was looking for exactly this node, it's so helpful and easy to juggle with json data.

@lublak
Copy link
Contributor Author

lublak commented Jan 5, 2023

@Joffcom copy pasta! :P But yes I move it to a community node.

@lublak what happened to the community node with jsonata? did you come around to implement it? was looking for exactly this node, it's so helpful and easy to juggle with json data.

Hi @cellerich,

I will start working on n8n nodes on 11.01.
There was some issues in my work. We rebuild the complete it department.
I will inform you :) I think I will have it available next week. Sry :/ that I was not available.

@cellerich
Copy link

I will start working on n8n nodes on 11.01.

This sounds very exciting. Thanks in advance!

@lublak
Copy link
Contributor Author

lublak commented Jan 13, 2023

@cellerich you can now follow the development here: https://github.com/lublak/n8n-nodes-jsonata :)
I will work on the weekend on this

@cellerich
Copy link

happy to look into it! Thanks a lot!

@lublak
Copy link
Contributor Author

lublak commented Jan 16, 2023

@cellerich currently waiting for this: jsonata-js/jsonata#613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/new Creation of an entirely new node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants