Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) add aws-firehose node #2609

Closed
wants to merge 2 commits into from
Closed

Conversation

quansenB
Copy link
Contributor

This PR adds an implementation of the aws firehose node. It is a part of #2205, which was requested to be split up.

@ivov ivov added node/new Creation of an entirely new node community Authored by a community member labels Dec 28, 2021
@quansenB quansenB changed the title add aws-firehose (feat) add aws-firehose node Dec 28, 2021
@sutidor
Copy link

sutidor commented Jan 19, 2022

Please kindly review this PR as the customer is waiting for this. Thank you.

@Joffcom
Copy link
Member

Joffcom commented Sep 9, 2022

Hey @quansenB,

Thanks for the contribution, It looks like you have already published this node to the Community Node Repository which is our preferred method for new node submissions.

In the future we may reach out to you about including your node in our main release, But for now I am going to close this PR. If you have any questions about this or need any help let us know.

@Joffcom Joffcom closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/new Creation of an entirely new node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants