Refactor credentials endpoints for user management #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
added
feature
packages/cli/src/Server.ts
Outdated
Comment on lines
1609
to
1611
| if (!savedCredential) { | ||
| throw new ResponseHelper.ResponseError('Failed to save credential', undefined, 500); | ||
| } |
There was a problem hiding this comment.
I think if the transaction fails we anyway never reach this code 🤔
There was a problem hiding this comment.
Found a third way - returning a value inside the transaction makes it available in the outer scope. Otherwise TS would be unable to tell that savedCredential is not undefined after the transaction.
ivov
commented
Jan 25, 2022
BHesseldieck
approved these changes
Jan 27, 2022
BHesseldieck
deleted the
user-management-backend-credentials-endpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned chokidar to fix build: #2696