Feature/n8n 2853 templates fe all pages ready #2720
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import N8nCard from './Card.vue'; | ||
|
|
||
| export default { | ||
| title: 'Atoms/Card', | ||
| component: N8nCard, | ||
| argTypes: { | ||
| title: { | ||
| control: { | ||
| type: 'text', | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| const Template = (args, { argTypes }) => ({ | ||
| props: Object.keys(argTypes), | ||
| components: { | ||
| N8nCard, | ||
| }, | ||
| template: '<n8n-card v-bind="$props"></n8n-card>', | ||
|
There was a problem hiding this comment. can you flourish this example more? so fill in the slots so it's not empty and a useful demo of the component |
||
| }); | ||
|
|
||
| export const Card = Template.bind({}); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <template> | ||
| <div :class="$style.card"> | ||
|
There was a problem hiding this comment. why does not the card have a border? |
||
| <div :class="$style.body"> | ||
| <n8n-heading :bold="true" size="small">{{ title }}</n8n-heading> | ||
| <div :class="$style.content"> | ||
| <slot name="content"></slot> | ||
| </div> | ||
| </div> | ||
| <div> | ||
| <slot name="button"></slot> | ||
| </div> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script lang="ts"> | ||
| export default { | ||
| name: 'n8n-card', | ||
| props: { | ||
| title: { | ||
| type: String, | ||
| default: '', | ||
| }, | ||
| }, | ||
| methods: { | ||
| }, | ||
| }; | ||
| </script> | ||
|
|
||
| <style lang="scss" module> | ||
| .card { | ||
| width: 100%; | ||
| min-height: 68px; | ||
|
There was a problem hiding this comment. let's give this card a specific height and width? that way if we need to add another size, we just it behind a prop. |
||
| margin-right: var(--spacing-2xs); | ||
| padding: var(--spacing-s); | ||
| background-color: var(--color-background-xlight); | ||
| border-bottom: 1px #dbdfe7 solid; | ||
|
There was a problem hiding this comment. please use css variables for colors |
||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .content { | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: space-around; | ||
| } | ||
| </style> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import N8nCard from './Card.vue'; | ||
|
|
||
| export default N8nCard; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import N8nImage from './Image.vue'; | ||
|
|
||
| export default { | ||
| title: 'Atoms/Image', | ||
| component: N8nImage, | ||
| argTypes: { | ||
| images: { | ||
| control: { | ||
| type: 'array', | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| const Template = (args, { argTypes }) => ({ | ||
| props: Object.keys(argTypes), | ||
| components: { | ||
| N8nImage, | ||
| }, | ||
| template: | ||
| '<n8n-image v-bind="$props"></n8n-image>', | ||
| }); | ||
|
|
||
| export const Image = Template.bind({}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to set a default value here