Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation at PATCH /workfows/:id #2819

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Fix validation at PATCH /workfows/:id #2819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf3cb60
:bug: Validate entity only if workflow
ivov Feb 14, 2022
6e3096f
:shirt: Fix build
ivov Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cli/src/Server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ class App {
this.app.use((req: express.Request, res: express.Response, next: express.NextFunction) => {
// Allow access also from frontend when developing
res.header('Access-Control-Allow-Origin', 'http://localhost:8080');
res.header('Access-Control-Allow-Credentials', true);
res.header('Access-Control-Allow-Credentials', 'true');
res.header('Access-Control-Allow-Methods', 'GET, POST, OPTIONS, PUT, PATCH, DELETE');
res.header(
'Access-Control-Allow-Headers',
Expand Down Expand Up @@ -963,7 +963,7 @@ class App {
}
}

if (Object.keys(updateData).length > 1 || updateData.active === undefined) {
if (updateData.name) {
updateData.updatedAt = this.getCurrentDate(); // required due to atomic update
await validateEntity(updateData);
}
Expand Down