Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N8N-3206 add xc token to nocodb #3073

Closed
wants to merge 9 commits into from

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Mar 30, 2022

Adds a second credential type to NocoDB to support API Tokens as well as User Tokens that are used for the Swagger interface
Adds credential testing for both credential types
Fixes an issue when the Host contains a trailing /

Original work was done in #2909

@Joffcom Joffcom added node/improvement New feature or request community Authored by a community member n8n team Authored by the n8n team labels Mar 30, 2022
@Joffcom
Copy link
Member Author

Joffcom commented May 3, 2022

Hey @valentina98,

We had this one on hold while we worked on merging another PR that has come in to update the API used, In the other PR what they have done is made it a bit more dynamic than what I had done based on your original PR.

const tokenType = (credentials.apiToken.toString().length > 40) ? 'xc-auth' : 'xc-token';

This would allow both options to work in the same credential without breaking anything and I think it might be easier for our users as they can just paste in either option and it will just work.

What do you think?

@Joffcom
Copy link
Member Author

Joffcom commented Jun 16, 2022

Closing as changes are merged into #3146

@Joffcom Joffcom closed this Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants