Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n8n-3571-node-improvement-discord-broken-rate #3311

Conversation

michael-radency
Copy link
Contributor

No description provided.

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team node/issue Issue with a node labels May 18, 2022
@janober janober merged commit b687ba1 into n8n-io:master May 27, 2022
@janober
Copy link
Member

janober commented May 27, 2022

Thanks a lot. Got merged.

@janober janober added the Upcoming Release Will be part of the upcoming release label May 27, 2022
@janober
Copy link
Member

janober commented May 30, 2022

Got released with n8n@0.179.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label May 30, 2022
janober added a commit that referenced this pull request Jun 5, 2022
* options and operations added

* IT WORKS!

* Added ReturnALL to GET method

* comit for PR

* updating shared operations

* (AWS): Allow only valid values of Region in the credentials modal

* fix(core): Fix issue that "closeFunction" got called twice

* fix(core): Prevent expressions XSS (#3366)

* ✨ Added checks for window object access in template strings.

* ✨ Added self, prompt and confirm to blocklist. Changed window usage condition.

* fix(editor): Fix conflicting hover states between sticky button and node view (#3368)

* 🐛 Fixing conflicting hover states between sticky button and node view.

* 🔨 Updating and optimizing sticky menu hover logic

* 📇 Removing redundant comments from `NodeView`.

* fix(editor): Fix credential display bug (#3372)

* ⚡ Filter credentials by version

* ⚡ Reuse helper

* fix(NextCloud Node): Fix folder list with Nextcloud v24 (#3386)

* initial fix for v24 folder listing

* implemented new credential methods

* Nodelinter fixes

* feat(PostBin Node): Add PostBin node  (#3236)

* 🚧 Initial progress on PostBin node.

* ✨ Implemented Bin and Request operations for PostBin node.

* 🚧 Reworked the node in the declarative way.

* 🚧 PosBin node refactoring after reworking it.

* ✨ Implemented Bin id parsing in PostBin node. Done some final refactoring and documentation.

* ⚡ Improvements

* ⚡ Add comments

* 👌Updating the PostBin node based on the product review

* 💄Updating PostBin node Bin ID validation logic

* ⚡ Small improvements

* ⚡ Transform the bin requests and add additional properties

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>

* feat(Todoist Node): Add support for specifying the parent task when adding and listing tasks (#3161)

* Todoist: Update parent field to parent_id

`parent` is deprecated.

* Todoist: Move Labels to "additional fields" when adding a task

Improves consistency with other operations.

* Todoist: Improve section re-load when switching projects

It only worked when creating tasks, due to naming and nesting
inconsistencies between different operations. Making it consistent
adds predictability and allows reuse between operations.

* Todoist: Add support for parent_id when creating and listing tasks

* ⚡ fixes

* ⚡ test credentials fix

* ⚡ parameters naming fix

* ⚡ undo for breaking change

* feat(Salesforce Node): Add country field (#3314)

* fix(Slack Node): Fix Channel->Kick (#3365)

* feat(core): Allow credential reuse on HTTP Request node (#3228)

* ✨ Create controller

* ⚡ Mount controller

* ✏️ Add error messages

* ✨ Create scopes fetcher

* ⚡ Account for non-existent credential type

* 📘 Type scopes request

* ⚡ Adjust error message

* 🧪 Add tests

* ✨ Introduce simple node versioning

* ⚡ Add example how to read version in node-code for custom logic

* 🐛 Fix setting of parameters

* 🐛 Fix another instance where it sets the wrong parameter

* ⚡ Remove unnecessary TOODs

* ✨ Re-version HTTP Request node

* 👕 Satisfy linter

* ⚡ Retrieve node version

* ⏪ Undo Jan's changes to Set node

* 🧪 Fix CI/CD for `/oauth2-credential` tests (#3230)

* 🐛 Fix notice warning missing background color (#3231)

* 🐛 Check for generic auth in node cred types

* ⚡ Refactor credentials dropdown for HTTP Request node (#3222)

* ⚡ Discoverability flow (#3229)

* ✨ Added node credentials type proxy. Changed node credentials input order.

* ⚡ Add computed property from versioning branch

* 🐛 Fix cred ref lost and unsaved

* ⚡ Make options consistent with cred type names

* ⚡ Use prop to set component order

* ⚡ Use constant and version

* ⚡ Fix rendering for generic auth creds

* ⚡ Mark as required on first selection

* ⚡ Implement discoverability flow

* ⚡ Mark as required on subsequent selections

* ⚡ Fix marking as required after cred deletion

* ⚡ Refactor to clean up

* ⚡ Detect position automatically

* ⚡ Add i18n to option label

* ⚡ Hide subtitle for custom action

* ⚡ Detect active credential type

* ⚡ Prop drilling to re-render select

* 🔥 Remove unneeded property

* ✏️ Rename arg

* 🔥 Remove unused import

* 🔥 Remove unneeded getters

* 🔥 Remove unused import

* ⚡ Generalize cred component positioning

* ⚡ Set up request

* 🐛 Fix edge case in endpoint

* ⚡ Display scopes alert box

* ⏪ Revert "Generalize cred comp positioning"

This reverts commit 75eea89.

* ⚡ Consolidate HTTPRN check

* ⚡ Fix hue percentage to degree

* 🔥 Remove unused import

* 🔥 Remove unused import

* 🔥 Remove unused class

* 🔥 Remove unused import

* 📘 Create type for HTTPRN v2 auth params

* ✏️ Rename check

* 🔥 Remove unused import

* ✏️ Add i18n to `reportUnsetCredential()`

* ⚡ Refactor Alex's spacing changes

* ⚡ Post-merge fixes

* ⚡ Add docs link

* 🔥 Exclude Notion OAuth cred

* ✏️ Update copy

* ✏️ Rename param

* 🎨 Reposition notice and simplify styling

* ✏️ Update copy

* ✏️ Update copy

* ⚡ Hide params during custom action

* ⚡ Show notice if any cred type supported

* 🐛 Prevent scopes text overflow

* 🔥 Remove superfluous check

* ✏️ Break up docstring

* 🎨 Tweak notice styling

* ⚡ Reorder cred param in Webhook node

* ✏️ Shorten cred name in scopes notice

* 🧪 Update Notice snapshots

* 🐛 Fix check when `globalRole` is `undefined`

* ⏪ Revert 3f2c4a6

* ⚡ Apply feedback from Product

* 🧪 Update snapshot

* ⚡ Adjust regex expansion pattern for singular

* 🔥 Remove unused import

* 🔥 Remove logging

* ⚡ Make `somethingElse` key more unique

* ⚡ Move something else to constants

* ⚡ Consolidate notice component

* ⚡ Apply latest feedback

* 🧪 Update tests

* 🧪 Update snapshot

* ✏️ Fix singular version

* 🧪 Finalize tests

* ✏️ Rename constant

* 🧪 Expand tests

* 🔥 Remove `truncate` prop

* 🚚 Move scopes fetching to store

* 🚚 Move method to component

* ⚡ Use constant

* ⚡ Refactor `Notice` component

* 🧪 Update tests

* 🔥 Remove unused keys

* ⚡ Inject custom API call option

* 🔥 Remove unused props

* 🎨 Use `compact` prop

* 🧪 Update snapshots

* 🚚 Move scopes to store

* 🚚 Move `nodeCredentialTypes` to parent

* ✏️ Rename cred types per branding

* 🐛 Clear scopes when none

* ⚡ Add default

* 🚚 Move `newHttpRequestNodeCredentialType` to parent

* 🔥 Remove test data

* ⚡ Separate lines for readability

* ⚡ Change reference from node to node name

* ✏️ Rename i18n keys

* ⚡ Refactor OAuth check

* 🔥 Remove unused key

* 🚚 Move `OAuth1/2 API` to i18n

* ⚡ Refactor `skipCheck`

* ⚡ Add `stopPropagation` and `preventDefault`

* 🚚 Move active credential scopes logic to store

* 🎨 Fix spacing for `NodeWebhooks` component

* ⚡ Implement feedback

* ⚡ Update HTTPRN default and issue copy

* Refactor to use `CredentialsSelect` param (#3304)

* ⚡ Refactor into cred type param

* ⚡ Componentize scopes notice

* 🔥 Remove unused data

* 🔥 Remove unused `loadOptions`

* ⚡ Componentize `NodeCredentialType`

* 🐛 Fix param validation

* 🔥 Remove dup methods

* ⚡ Refactor all references to `isHttpRequestNodeV2`

* 🎨 Fix styling

* 🔥 Remove unused import

* 🔥 Remove unused properties

* 🎨 Fix spacing for Pipedrive Trigger node

* 🎨 Undo Webhook node styling change

* 🔥 Remove unused style

* ⚡ Cover `httpHeaderAuth` edge case

* 🐛 Fix `this.node` reference

* 🚚 Rename to `credentialsSelect`

* 🐛 Fix mistaken renaming

* ⚡ Set one attribute per line

* ⚡ Move condition to instantiation site

* 🚚 Rename prop

* ⚡ Refactor away `prepareScopesNotice`

* ✏️ Rename i18n keys

* ✏️ Update i18n calls

* ✏️ Add more i18n keys

* 🔥 Remove unused props

* ✏️ Add explanatory comment

* ⚡ Adjust check in `hasProxyAuth`

* ⚡ Refactor `credentialSelected` from prop to event

* ⚡ Eventify `valueChanged`, `setFocus`, `onBlur`

* ⚡ Eventify `optionSelected`

* ⚡ Add `noDataExpression`

* 🔥 Remove logging

* 🔥 Remove URL from scopes

* ⚡ Disregard expressions for display

* 🎨 Use CSS modules

* 📘 Tigthen interface

* 🐛 Fix generic auth display

* 🐛 Fix generic auth validation

* 📘 Loosen type

* 🚚 Move event params to end

* ⚡ Generalize reference

* ⚡ Refactor generic auth as `credentialsSelect` param

* ⏪ Restore check for `httpHeaderAuth `

* 🚚 Rename `existing` to `predefined`

* Extend metrics for HTTP Request node (#3282)

* ⚡ Extend metrics

* 🧪 Add tests

* ⚡ Update param names

Co-authored-by: Alex Grozav <alex@grozav.com>

* ⚡ Update check per new branch

* ⚡ Include generic auth check

* ⚡ Adjust telemetry (#3359)

* ⚡ Filter credential types by label

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>

* ⬆️ Update package-lock.json file

* 🔖 Release n8n-workflow@0.100.0

* ⬆️ Set n8n-workflow@0.100.0 on n8n-core

* 🔖 Release n8n-core@0.118.0

* ⬆️ Set n8n-core@0.118.0 and n8n-workflow@0.100.0 on n8n-node-dev

* 🔖 Release n8n-node-dev@0.57.0

* ⬆️ Set n8n-core@0.118.0 and n8n-workflow@0.100.0 on n8n-nodes-base

* 🔖 Release n8n-nodes-base@0.176.0

* 🔖 Release n8n-design-system@0.21.0

* ⬆️ Set n8n-design-system@0.21.0 and n8n-workflow@0.100.0 on n8n-editor-ui

* 🔖 Release n8n-editor-ui@0.144.0

* ⬆️ Set n8n-core@0.118.0, n8n-editor-ui@0.144.0, n8n-nodes-base@0.176.0 and n8n-workflow@0.100.0 on n8n

* 🔖 Release n8n@0.178.0

* 🔖 Update main package.json to 0.178.0

* 📚 Update CHANGELOG.md with version 0.178.0

* fix(editor): Fix problem with HTTP Request Node 1 credentials to be set (#3371)

* 🔖 Release n8n-editor-ui@0.144.1

* ⬆️ Set n8n-editor-ui@0.144.1 on n8n

* 🔖 Release n8n@0.178.1

* 🔖 Update main package.json to 0.178.1

* 📚 Update CHANGELOG.md with version 0.178.1

* fix(editor): Fix parameter loading bug (#3374)

* fix parameter loading bug

* remove duplicate check

* 🔖 Release n8n-editor-ui@0.144.2

* ⬆️ Set n8n-editor-ui@0.144.2 on n8n

* 🔖 Release n8n@0.178.2

* 🔖 Update main package.json to 0.178.2

* 📚 Update CHANGELOG.md with version 0.178.2

* ⚡ Improvements

* fix(core): Fix issue that "closeFunction" got called twice

* fix(core): Prevent expressions XSS (#3366)

* ✨ Added checks for window object access in template strings.

* ✨ Added self, prompt and confirm to blocklist. Changed window usage condition.

* fix(editor): Fix conflicting hover states between sticky button and node view (#3368)

* 🐛 Fixing conflicting hover states between sticky button and node view.

* 🔨 Updating and optimizing sticky menu hover logic

* 📇 Removing redundant comments from `NodeView`.

* fix(editor): Fix credential display bug (#3372)

* ⚡ Filter credentials by version

* ⚡ Reuse helper

* fix(NextCloud Node): Fix folder list with Nextcloud v24 (#3386)

* initial fix for v24 folder listing

* implemented new credential methods

* Nodelinter fixes

* feat(PostBin Node): Add PostBin node  (#3236)

* 🚧 Initial progress on PostBin node.

* ✨ Implemented Bin and Request operations for PostBin node.

* 🚧 Reworked the node in the declarative way.

* 🚧 PosBin node refactoring after reworking it.

* ✨ Implemented Bin id parsing in PostBin node. Done some final refactoring and documentation.

* ⚡ Improvements

* ⚡ Add comments

* 👌Updating the PostBin node based on the product review

* 💄Updating PostBin node Bin ID validation logic

* ⚡ Small improvements

* ⚡ Transform the bin requests and add additional properties

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>

* ⚡ Simplify auth

* 👕 Fix lint issue

Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Jan Oberhauser <janober@users.noreply.github.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Milorad FIlipović <miloradfilipovic19@gmail.com>
Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>

* fix(core): Fix problem with uploading large files (#3370)

* ⚡ fix

* ⚡ moved setting to axios config

* fix(editor): Fix component in executions list failing custom validator (#3284)

* 🐛 Adjust size to custom validator

* ⏪ Undo size change

* ⚡ Add size to component validator

* fix(Discord Node): Fix broken rate limit handling (#3311)

* 🔨 fix and additional option to return response headers

* ⚡ Remove "return response headers" parameter

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>

* feat(ServiceNow Node): Add attachment functionality (#3137)

* ✨ Add ServiceNow attachment functionality

* 🔨 download fix

* ⚡ improvements

* ⚡ parameter name fix

* ⚡ download attachment for get all operation

* ⚡ filters update

* ⚡ hint update

* ⚡ Small improvements

Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>

* ⚡ Update URLs to n8n.io API (#3391)

* fix(core): Fix migrations on non-public Postgres schema (#3356)

* 🐛 Fix UM migration

* ⚡ Account for schema in `search_path`

* 🔥 Remove unneeded schema refs

* 🧪 Account for alt schema in DB testing

* ⚡ Add schema to `IncreaseTypeVarcharLimit`

* ⚡ Set `search_path` in every migration

* ⚡ Set `search_path` in down migrations

* refactor(core): Improve error message

* feat(RabbitMQ Trigger Node): Make message acknowledgement and parallel processing configurable (#3385)

* feat(RabbitMQ Trigger Node): Make message acknowledgement and concurrent
processing configurable

* ⚡ Make sure that messages do not get executed multiple times

* 👕 Fix lint issue

* 🐛 Fix issue that for manual executions in "own" mode messages got
know acknowledged

* ⚡ Increment count now that console.log got removed

* ⚡ Improvements

* ⚡ Fix default value

* ⚡ Improve display name

* fix(Gmail Node): Fix sending attachments when filesystem mode is used (#3396)

* fix(Google Sheet Node): Fix issue with null values and "Use Header Names as JSON Paths" option (#3395)

* fixed Google Sheet 'Use Header Names as JSON Paths' issue when input data contains null values. https://community.n8n.io/t/error-cannot-read-properties-of-null-reading-tostring/14385/2

* ⚡ Update URLs to n8n.io API (