Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n8n-3587-node-param-display-name-miscased #3449

Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,7 @@ module.exports = {
'n8n-nodes-base/node-param-placeholder-miscased-id': 'error',
'n8n-nodes-base/node-param-description-miscased-url': 'error',
'n8n-nodes-base/node-param-option-name-wrong-for-upsert': 'error',
'n8n-nodes-base/node-param-display-name-miscased': 'error',
},
},
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const accountContactFields: INodeProperties[] = [
default: {},
options: [
{
displayName: 'Job title',
displayName: 'Job Title',
name: 'jobTitle',
type: 'string',
default: '',
Expand Down Expand Up @@ -162,7 +162,7 @@ export const accountContactFields: INodeProperties[] = [
default: {},
options: [
{
displayName: 'Job title',
displayName: 'Job Title',
name: 'jobTitle',
type: 'string',
default: '',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,15 +164,15 @@ export class ActiveCampaign implements INodeType {
value: 'deal',
},
{
name: 'E-commerce Order',
name: 'E-Commerce Order',
value: 'ecommerceOrder',
},
{
name: 'E-Commerce Customer',
value: 'ecommerceCustomer',
},
{
name: 'E-commerce Order Product',
name: 'E-Commerce Order Product',
value: 'ecommerceOrderProducts',
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const connectionFields: INodeProperties[] = [
description: 'The name of the service',
},
{
displayName: 'External accout ID',
displayName: 'External Accout ID',
Copy link
Contributor

@ivov ivov Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope but quick to fix: Account

name: 'externalid',
type: 'string',
default: '',
Expand Down Expand Up @@ -193,7 +193,7 @@ export const connectionFields: INodeProperties[] = [
description: 'The name of the service',
},
{
displayName: 'External accout ID',
displayName: 'External Accout ID',
Copy link
Contributor

@ivov ivov Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope but quick to fix: Account

name: 'externalid',
type: 'string',
default: '',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export const contactFields: INodeProperties[] = [
description: 'The email of the contact to create',
},
{
displayName: 'Update if exists',
displayName: 'Update if Exists',
name: 'updateIfExists',
type: 'boolean',
displayOptions: {
Expand Down
32 changes: 16 additions & 16 deletions packages/nodes-base/nodes/ActiveCampaign/DealDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const dealOperations: INodeProperties[] = [
description: 'Create a deal note',
},
{
name: 'Update deal note',
name: 'Update Deal Note',
value: 'updateNote',
description: 'Update a deal note',
},
Expand Down Expand Up @@ -88,7 +88,7 @@ export const dealFields: INodeProperties[] = [
description: 'The title of the deal',
},
{
displayName: 'Deal\'s contact ID',
displayName: 'Deal\'s Contact ID',
name: 'contact',
type: 'number',
default: 0,
Expand All @@ -106,7 +106,7 @@ export const dealFields: INodeProperties[] = [
description: 'The ID of the deal\'s contact',
},
{
displayName: 'Deal value',
displayName: 'Deal Value',
name: 'value',
type: 'number',
default: 0,
Expand Down Expand Up @@ -143,7 +143,7 @@ export const dealFields: INodeProperties[] = [
description: 'The currency of the deal in 3-character ISO format',
},
{
displayName: 'Deal pipeline ID',
displayName: 'Deal Pipeline ID',
name: 'group',
type: 'string',
default: '',
Expand All @@ -160,7 +160,7 @@ export const dealFields: INodeProperties[] = [
description: 'The pipeline ID of the deal',
},
{
displayName: 'Deal stage ID',
displayName: 'Deal Stage ID',
name: 'stage',
type: 'string',
default: '',
Expand All @@ -177,7 +177,7 @@ export const dealFields: INodeProperties[] = [
description: 'The stage ID of the deal',
},
{
displayName: 'Deal owner ID',
displayName: 'Deal Owner ID',
name: 'owner',
type: 'string',
default: '',
Expand Down Expand Up @@ -219,14 +219,14 @@ export const dealFields: INodeProperties[] = [
},

{
displayName: 'Deal percentage',
displayName: 'Deal Percentage',
name: 'percent',
type: 'number',
default: 0,
description: 'The percentage of the deal',
},
{
displayName: 'Deal status',
displayName: 'Deal Status',
name: 'status',
type: 'number',
default: 0,
Expand Down Expand Up @@ -282,14 +282,14 @@ export const dealFields: INodeProperties[] = [
description: 'The title of the deal',
},
{
displayName: 'Deal\'s contact ID',
displayName: 'Deal\'s Contact ID',
name: 'contact',
type: 'number',
default: 0,
description: 'The ID of the deal\'s contact',
},
{
displayName: 'Deal value',
displayName: 'Deal Value',
name: 'value',
type: 'number',
default: 0,
Expand All @@ -311,35 +311,35 @@ export const dealFields: INodeProperties[] = [
description: 'The description of the deal',
},
{
displayName: 'Deal pipeline ID',
displayName: 'Deal Pipeline ID',
name: 'group',
type: 'string',
default: '',
description: 'The pipeline ID of the deal',
},
{
displayName: 'Deal stage ID',
displayName: 'Deal Stage ID',
name: 'stage',
type: 'string',
default: '',
description: 'The stage ID of the deal',
},
{
displayName: 'Deal owner ID',
displayName: 'Deal Owner ID',
name: 'owner',
type: 'string',
default: '',
description: 'The owner ID of the deal',
},
{
displayName: 'Deal percentage',
displayName: 'Deal Percentage',
name: 'percent',
type: 'number',
default: 0,
description: 'The percentage of the deal',
},
{
displayName: 'Deal status',
displayName: 'Deal Status',
name: 'status',
type: 'number',
default: 0,
Expand Down Expand Up @@ -459,7 +459,7 @@ export const dealFields: INodeProperties[] = [
description: 'The ID of the deal note',
},
{
displayName: 'Deal note ID',
displayName: 'Deal Note ID',
name: 'dealNoteId',
type: 'number',
default: '',
Expand Down
24 changes: 12 additions & 12 deletions packages/nodes-base/nodes/ActiveCampaign/EcomOrderDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export const ecomOrderFields: INodeProperties[] = [
description: 'The ID of the order in the external service. ONLY REQUIRED IF EXTERNALCHECKOUTID NOT INCLUDED.',
},
{
displayName: 'External checkout ID',
displayName: 'External Checkout ID',
name: 'externalcheckoutid',
type: 'string',
default: '',
Expand All @@ -93,7 +93,7 @@ export const ecomOrderFields: INodeProperties[] = [
description: 'The ID of the cart in the external service. ONLY REQUIRED IF EXTERNALID IS NOT INCLUDED.',
},
{
displayName: 'Order source',
displayName: 'Order Source',
name: 'source',
type: 'number',
default: 0,
Expand Down Expand Up @@ -129,7 +129,7 @@ export const ecomOrderFields: INodeProperties[] = [
description: 'The email address of the customer who placed the order',
},
{
displayName: 'Total price',
displayName: 'Total Price',
name: 'totalPrice',
type: 'number',
default: 0,
Expand All @@ -147,7 +147,7 @@ export const ecomOrderFields: INodeProperties[] = [
description: 'The total price of the order in cents, including tax and shipping charges. (i.e. $456.78 => 45678). Must be greater than or equal to zero.',
},
{
displayName: 'Order currency',
displayName: 'Order Currency',
name: 'currency',
type: 'options',
default: 'eur',
Expand Down Expand Up @@ -280,7 +280,7 @@ export const ecomOrderFields: INodeProperties[] = [
description: 'The quantity ordered',
},
{
displayName: 'Product external ID',
displayName: 'Product External ID',
name: 'externalid',
type: 'string',
default: '',
Expand Down Expand Up @@ -370,7 +370,7 @@ export const ecomOrderFields: INodeProperties[] = [
description: 'The URL for the order in the external service',
},
{
displayName: 'External updated date',
displayName: 'External Updated Date',
name: 'externalUpdatedDate',
type: 'dateTime',
default: '',
Expand Down Expand Up @@ -440,14 +440,14 @@ export const ecomOrderFields: INodeProperties[] = [
description: 'The ID of the order in the external service. ONLY REQUIRED IF EXTERNALCHECKOUTID NOT INCLUDED.',
},
{
displayName: 'External checkout ID',
displayName: 'External Checkout ID',
name: 'externalcheckoutid',
type: 'string',
default: '',
description: 'The ID of the cart in the external service. ONLY REQUIRED IF EXTERNALID IS NOT INCLUDED.',
},
{
displayName: 'Order source',
displayName: 'Order Source',
name: 'source',
type: 'number',
default: 0,
Expand All @@ -461,14 +461,14 @@ export const ecomOrderFields: INodeProperties[] = [
description: 'The email address of the customer who placed the order',
},
{
displayName: 'Total price',
displayName: 'Total Price',
name: 'totalPrice',
type: 'number',
default: 0,
description: 'The total price of the order in cents, including tax and shipping charges. (i.e. $456.78 => 45678). Must be greater than or equal to zero.',
},
{
displayName: 'Order currency',
displayName: 'Order Currency',
name: 'currency',
type: 'options',
default: 'eur',
Expand Down Expand Up @@ -533,7 +533,7 @@ export const ecomOrderFields: INodeProperties[] = [
description: 'The URL for the order in the external service',
},
{
displayName: 'External updated date',
displayName: 'External Updated Date',
name: 'externalUpdatedDate',
type: 'dateTime',
default: '',
Expand Down Expand Up @@ -588,7 +588,7 @@ export const ecomOrderFields: INodeProperties[] = [
description: 'The quantity ordered',
},
{
displayName: 'Product external ID',
displayName: 'Product External ID',
name: 'externalid',
type: 'string',
default: '',
Expand Down
6 changes: 3 additions & 3 deletions packages/nodes-base/nodes/ActiveCampaign/currencies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const allCurrencies = [
{ name: 'Hungarian Forint', value: 'huf' },
{ name: 'Indonesian Rupiah', value: 'idr' },
{ name: 'Israeli New Sheqel', value: 'ils' },
{ name: 'Manx pound', value: 'imp' },
{ name: 'Manx Pound', value: 'imp' },
{ name: 'Indian Rupee', value: 'inr' },
{ name: 'Iraqi Dinar', value: 'iqd' },
{ name: 'Iranian Rial', value: 'irr' },
Expand Down Expand Up @@ -97,7 +97,7 @@ export const allCurrencies = [
{ name: 'Myanma Kyat', value: 'mmk' },
{ name: 'Mongolian Tugrik', value: 'mnt' },
{ name: 'Macanese Pataca', value: 'mop' },
{ name: 'Mauritanian Ouguiya (pre-2018)', value: 'mro' },
{ name: 'Mauritanian Ouguiya (Pre-2018)', value: 'mro' },
{ name: 'Mauritanian Ouguiya', value: 'mru' },
{ name: 'Mauritian Rupee', value: 'mur' },
{ name: 'Maldivian Rufiyaa', value: 'mvr' },
Expand Down Expand Up @@ -135,7 +135,7 @@ export const allCurrencies = [
{ name: 'Somali Shilling', value: 'sos' },
{ name: 'Surinamese Dollar', value: 'srd' },
{ name: 'South Sudanese Pound', value: 'ssp' },
{ name: 'São Tomé and Príncipe Dobra (pre-2018)', value: 'std' },
{ name: 'São Tomé and Príncipe Dobra (Pre-2018)', value: 'std' },
{ name: 'São Tomé and Príncipe Dobra', value: 'stn' },
{ name: 'Salvadoran Colón', value: 'svc' },
{ name: 'Syrian Pound', value: 'syp' },
Expand Down
8 changes: 4 additions & 4 deletions packages/nodes-base/nodes/AgileCrm/CompanyDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export const companyFields: INodeProperties[] = [
type: 'options',
options: [
{
name: 'Any filter',
name: 'Any Filter',
value: 'anyFilter',
},
{
Expand Down Expand Up @@ -528,7 +528,7 @@ export const companyFields: INodeProperties[] = [
},
options: [
{
displayName: 'Website properties.',
displayName: 'Website Properties.',
name: 'websiteProperties',
values: [
{
Expand Down Expand Up @@ -643,7 +643,7 @@ export const companyFields: INodeProperties[] = [
/* company:delete */
/* -------------------------------------------------------------------------- */
{
displayName: 'company ID',
displayName: 'Company ID',
name: 'companyId',
type: 'string',
required: true,
Expand Down Expand Up @@ -824,7 +824,7 @@ export const companyFields: INodeProperties[] = [
},
options: [
{
displayName: 'Website properties.',
displayName: 'Website Properties.',
name: 'websiteProperties',
values: [
{
Expand Down
Loading