Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N8n 3603 node param options type unsorted items #3459

Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,7 @@ module.exports = {
'n8n-nodes-base/node-param-placeholder-miscased-id': 'error',
'n8n-nodes-base/node-param-description-miscased-url': 'error',
'n8n-nodes-base/node-param-option-name-wrong-for-upsert': 'error',
'n8n-nodes-base/node-param-options-type-unsorted-items': 'error',
'n8n-nodes-base/node-param-default-wrong-for-string': 'error',
'n8n-nodes-base/node-param-default-wrong-for-number': 'error',
},
Expand Down
16 changes: 8 additions & 8 deletions packages/nodes-base/nodes/ActiveCampaign/ActiveCampaign.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ export class ActiveCampaign implements INodeType {
name: 'Account Contact',
value: 'accountContact',
},
{
name: 'Connection',
value: 'connection',
},
{
name: 'Contact',
value: 'contact',
Expand All @@ -155,22 +159,18 @@ export class ActiveCampaign implements INodeType {
name: 'Contact Tag',
value: 'contactTag',
},
{
name: 'Connection',
value: 'connection',
},
{
name: 'Deal',
value: 'deal',
},
{
name: 'E-commerce Order',
value: 'ecommerceOrder',
},
{
name: 'E-Commerce Customer',
value: 'ecommerceCustomer',
},
{
name: 'E-commerce Order',
value: 'ecommerceOrder',
},
{
name: 'E-commerce Order Product',
value: 'ecommerceOrderProducts',
Expand Down
16 changes: 8 additions & 8 deletions packages/nodes-base/nodes/ActiveCampaign/ContactDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -405,26 +405,26 @@ export const contactFields: INodeProperties[] = [
name: 'status',
type: 'options',
options: [
{
name: 'Active',
value: 1,
},
{
name: 'Any',
value: -1,
},
{
name: 'Unconfirmed',
value: 0,
name: 'Bounced',
value: 3,
},
{
name: 'Active',
value: 1,
name: 'Unconfirmed',
value: 0,
},
{
name: 'Unsubscribed',
value: 2,
},
{
name: 'Bounced',
value: 3,
},
],
default: '',
},
Expand Down
10 changes: 5 additions & 5 deletions packages/nodes-base/nodes/ActiveCampaign/DealDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ export const dealOperations: INodeProperties[] = [
value: 'create',
description: 'Create a deal',
},
{
name: 'Create Note',
value: 'createNote',
description: 'Create a deal note',
},
{
name: 'Delete',
value: 'delete',
Expand All @@ -49,11 +54,6 @@ export const dealOperations: INodeProperties[] = [
value: 'update',
description: 'Update a deal',
},
{
name: 'Create Note',
value: 'createNote',
description: 'Create a deal note',
},
{
name: 'Update deal note',
value: 'updateNote',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,6 @@ export class AcuitySchedulingTrigger implements INodeType {
required: true,
default: '',
options: [
{
name: 'appointment.scheduled',
value: 'appointment.scheduled',
description: 'is called once when an appointment is initially booked',
},
{
name: 'appointment.rescheduled',
value: 'appointment.rescheduled',
description: 'is called when the appointment is rescheduled to a new time',
},
{
name: 'appointment.canceled',
value: 'appointment.canceled',
Expand All @@ -103,6 +93,16 @@ export class AcuitySchedulingTrigger implements INodeType {
value: 'appointment.changed',
description: 'is called when the appointment is changed in any way',
},
{
name: 'appointment.rescheduled',
value: 'appointment.rescheduled',
description: 'is called when the appointment is rescheduled to a new time',
},
{
name: 'appointment.scheduled',
value: 'appointment.scheduled',
description: 'is called once when an appointment is initially booked',
},
{
name: 'order.completed',
value: 'order.completed',
Expand Down
28 changes: 14 additions & 14 deletions packages/nodes-base/nodes/AgileCrm/CompanyDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -230,32 +230,32 @@ export const companyFields: INodeProperties[] = [
type: 'options',
options: [
{
name: 'Equals',
value: 'EQUALS',
},
{
name: 'Not Equal',
value: 'NOTEQUALS',
name: 'After',
value: 'AFTER',
},
{
name: 'Last',
value: 'LAST',
name: 'Before',
value: 'BEFORE',
},
{
name: 'Between',
value: 'BETWEEN',
},
{
name: 'On',
value: 'ON',
name: 'Equals',
value: 'EQUALS',
},
{
name: 'Before',
value: 'BEFORE',
name: 'Last',
value: 'LAST',
},
{
name: 'After',
value: 'AFTER',
name: 'Not Equal',
value: 'NOTEQUALS',
},
{
name: 'On',
value: 'ON',
},
],
default: 'EQUALS',
Expand Down
44 changes: 22 additions & 22 deletions packages/nodes-base/nodes/AgileCrm/ContactDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -230,32 +230,32 @@ export const contactFields: INodeProperties[] = [
type: 'options',
options: [
{
name: 'Equals',
value: 'EQUALS',
},
{
name: 'Not Equal',
value: 'NOTEQUALS',
name: 'After',
value: 'AFTER',
},
{
name: 'Last',
value: 'LAST',
name: 'Before',
value: 'BEFORE',
},
{
name: 'Between',
value: 'BETWEEN',
},
{
name: 'On',
value: 'ON',
name: 'Equals',
value: 'EQUALS',
},
{
name: 'Before',
value: 'BEFORE',
name: 'Last',
value: 'LAST',
},
{
name: 'After',
value: 'AFTER',
name: 'Not Equal',
value: 'NOTEQUALS',
},
{
name: 'On',
value: 'ON',
},
],
default: 'EQUALS',
Expand Down Expand Up @@ -645,14 +645,14 @@ export const contactFields: INodeProperties[] = [
name: 'Other',
value: 'other',
},
{
name: 'Work Fax',
value: 'workFax',
},
{
name: 'Work',
value: 'work',
},
{
name: 'Work Fax',
value: 'workFax',
},
],
},
{
Expand Down Expand Up @@ -1106,14 +1106,14 @@ export const contactFields: INodeProperties[] = [
name: 'Other',
value: 'other',
},
{
name: 'Work Fax',
value: 'workFax',
},
{
name: 'Work',
value: 'work',
},
{
name: 'Work Fax',
value: 'workFax',
},
],
},
{
Expand Down
8 changes: 4 additions & 4 deletions packages/nodes-base/nodes/Asana/Asana.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,14 @@ export class Asana implements INodeType {
name: 'Task Comment',
value: 'taskComment',
},
{
name: 'Task Tag',
value: 'taskTag',
},
{
name: 'Task Project',
value: 'taskProject',
},
{
name: 'Task Tag',
value: 'taskTag',
},
{
name: 'User',
value: 'user',
Expand Down
16 changes: 8 additions & 8 deletions packages/nodes-base/nodes/Aws/S3/FileDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,10 @@ export const fileFields: INodeProperties[] = [
name: 'Deep Archive',
value: 'deepArchive',
},
{
name: 'Glacier',
value: 'glacier',
},
{
name: 'Intelligent Tiering',
value: 'intelligentTiering',
Expand All @@ -295,10 +299,6 @@ export const fileFields: INodeProperties[] = [
name: 'One Zone IA',
value: 'onezoneIA',
},
{
name: 'Glacier',
value: 'glacier',
},
{
name: 'Standard',
value: 'standard',
Expand Down Expand Up @@ -640,6 +640,10 @@ export const fileFields: INodeProperties[] = [
name: 'Deep Archive',
value: 'deepArchive',
},
{
name: 'Glacier',
value: 'glacier',
},
{
name: 'Intelligent Tiering',
value: 'intelligentTiering',
Expand All @@ -648,10 +652,6 @@ export const fileFields: INodeProperties[] = [
name: 'One Zone IA',
value: 'onezoneIA',
},
{
name: 'Glacier',
value: 'glacier',
},
{
name: 'Standard',
value: 'standard',
Expand Down
8 changes: 4 additions & 4 deletions packages/nodes-base/nodes/Aws/S3/FolderDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,10 @@ export const folderFields: INodeProperties[] = [
name: 'Deep Archive',
value: 'deepArchive',
},
{
name: 'Glacier',
value: 'glacier',
},
{
name: 'Intelligent Tiering',
value: 'intelligentTiering',
Expand All @@ -123,10 +127,6 @@ export const folderFields: INodeProperties[] = [
name: 'One Zone IA',
value: 'onezoneIA',
},
{
name: 'Glacier',
value: 'glacier',
},
{
name: 'Reduced Redundancy',
value: 'RecudedRedundancy',
Expand Down
16 changes: 8 additions & 8 deletions packages/nodes-base/nodes/Aws/Transcribe/AwsTranscribe.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,25 +144,25 @@ export class AwsTranscribe implements INodeType {
value: 'en-GB',
},
{
name: 'Irish English',
value: 'en-IE',
name: 'German',
value: 'de-DE',
},
{
name: 'Indian English',
value: 'en-IN',
},
{
name: 'Spanish',
value: 'es-ES',
},
{
name: 'German',
value: 'de-DE',
name: 'Irish English',
value: 'en-IE',
},
{
name: 'Russian',
value: 'ru-RU',
},
{
name: 'Spanish',
value: 'es-ES',
},
],
displayOptions: {
show: {
Expand Down
Loading