Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Add fileExtension from FileTypeResult to buffer data #3591

Merged
merged 2 commits into from
Jun 26, 2022
Merged

♻️ Add fileExtension from FileTypeResult to buffer data #3591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b14f53
:recycle: Add fileExtension from FileTypeResult to buffer data
Jun 23, 2022
b1d0cbb
:zap: Minor improvement
janober Jun 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/core/src/NodeExecuteFunctions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,7 @@ export async function prepareBinaryData(
filePath?: string,
mimeType?: string,
): Promise<IBinaryData> {
let fileExtension: string | undefined;
if (!mimeType) {
// If no mime type is given figure it out

Expand All @@ -825,6 +826,7 @@ export async function prepareBinaryData(
const fileTypeData = await fromBuffer(binaryData);
if (fileTypeData) {
mimeType = fileTypeData.mime;
fileExtension = fileTypeData.ext;
}
}

Expand All @@ -836,6 +838,7 @@ export async function prepareBinaryData(

const returnData: IBinaryData = {
mimeType,
fileExtension,
data: '',
};

Expand Down