feat(cli): Load all nodes and credentials code in isolation - N8N-4362 #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
force-pushed
the
load-nodes-and-credentials-in-isolated-contexts
branch
from
d2cd702
to
f3a449e
Compare
n8n-assistant
bot
added
core
netroy
force-pushed
the
load-nodes-and-credentials-in-isolated-contexts
branch
from
f3a449e
to
4eb518d
Compare
|
Hey @netroy thank you for your contribution! I'll start reviewing and testing this today and I'll keep you posted. |
netroy
force-pushed
the
load-nodes-and-credentials-in-isolated-contexts
branch
from
4eb518d
to
04288a9
Compare
netroy
changed the title
netroy
force-pushed
the
load-nodes-and-credentials-in-isolated-contexts
branch
from
04288a9
to
0dc47c8
Compare
krynble
approved these changes
Sep 9, 2022
|
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
n8n-io#3906) [N8N-4362] Load all nodes and credentials code in isolation Co-authored-by: Omar Ajoue <krynble@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all nodes and credentials are loaded in the same global context as the rest of the app. This becomes a security nightmare as we have more and more community nodes.
We can fix this by loading all nodes and credentials code in isolated contexts, which in turn also reduces any possibilities of external side-effects creating trouble for any inividial node or credential.
PS: This breaks the functionality in the
Functionnode where one can refer to env variables with expression like$ENV_VAR.