Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand obfuscation to User Management credential sharing #4070

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Expand obfuscation to User Management credential sharing #4070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/editor-ui/src/components/CredentialCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<credential-icon :credential-type-name="credentialType ? credentialType.name : ''" />
</template>
<template #header>
<n8n-heading tag="h2" bold :class="$style['card-heading']">
<n8n-heading tag="h2" bold class="ph-no-capture" :class="$style['card-heading']">
{{ data.name }}
</n8n-heading>
</template>
Expand Down
8 changes: 5 additions & 3 deletions packages/editor-ui/src/components/CredentialEdit/CredentialConfig.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,11 @@
v-else
:features="[EnterpriseEditionFeature.Sharing]"
>
<n8n-info-tip :bold="false">
{{ $locale.baseText('credentialEdit.credentialEdit.info.sharee', { interpolate: { credentialOwnerName } }) }}
</n8n-info-tip>
<div class="ph-no-capture">
<n8n-info-tip :bold="false">
{{ $locale.baseText('credentialEdit.credentialEdit.info.sharee', { interpolate: { credentialOwnerName } }) }}
</n8n-info-tip>
</div>
</enterprise-edition>

<CredentialInputs
Expand Down
4 changes: 2 additions & 2 deletions packages/editor-ui/src/components/Node.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@
<div :class="{'disabled-linethrough': true, success: workflowDataItems > 0}" v-if="showDisabledLinethrough"></div>
</div>
<div class="node-description">
<div class="node-name" :title="nodeTitle">
<div class="node-name ph-no-capture" :title="nodeTitle">
<p>
{{ nodeTitle }}
</p>
<p v-if="data.disabled">
({{ $locale.baseText('node.disabled') }})
</p>
</div>
<div v-if="nodeSubtitle !== undefined" class="node-subtitle ph-no-capture" :title="nodeSubtitle">
<div v-if="nodeSubtitle !== undefined" class="node-subtitle" :title="nodeSubtitle">
{{ nodeSubtitle }}
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/editor-ui/src/components/NodeTitle.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<n8n-button type="primary" size="small" @click="onRename" :label="$locale.baseText('ndv.title.rename')" />
</div>
</div>
<div slot="reference" :class="{[$style.title]: true, [$style.hoverable]: !readOnly}">
<div class="ph-no-capture" slot="reference" :class="{[$style.title]: true, [$style.hoverable]: !readOnly}">
{{ value }}
<div :class="$style.editIconContainer">
<font-awesome-icon :class="$style.editIcon" icon="pencil-alt" v-if="!readOnly" />
Expand Down
4 changes: 3 additions & 1 deletion packages/editor-ui/src/views/CredentialsView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<n8n-loading :class="$style['card-loading']" variant="custom"/>
</div>
<template v-else>
<div v-if="allCredentials.length === 0">
<div class="ph-no-capture" v-if="allCredentials.length === 0">
<n8n-action-box
emoji="👋"
:heading="$locale.baseText(currentUser.firstName ? 'credentials.empty.heading' : 'credentials.empty.heading.userNotSetup', {
Expand Down Expand Up @@ -133,6 +133,7 @@
/>
<n8n-select
v-model="filters.ownedBy"
class="ph-no-capture"
:class="$style['user-select']"
size="small"
filterable
Expand Down Expand Up @@ -167,6 +168,7 @@
/>
<n8n-select
v-model="filters.sharedWith"
class="ph-no-capture"
:class="$style['user-select']"
size="small"
filterable
Expand Down