-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Implement HTML sanitization for Notification and Message components #4081
Merged
OlegIvaniv
merged 5 commits into
master
from
n8n-4385-notification-component-xss-vulnerability
Sep 13, 2022
Merged
feat(editor): Implement HTML sanitization for Notification and Message components #4081
OlegIvaniv
merged 5 commits into
master
from
n8n-4385-notification-component-xss-vulnerability
Sep 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TMLString` option of Notification and Message components
OlegIvaniv
added
core
Enhancement outside /nodes-base and /editor-ui
ui
Enhancement in /editor-ui or /design-system
tech debt
labels
Sep 12, 2022
mutdmour
reviewed
Sep 12, 2022
mutdmour
reviewed
Sep 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one small comment to address
@mutdmour I've addressed the removal of the unused |
mutdmour
approved these changes
Sep 13, 2022
OlegIvaniv
deleted the
n8n-4385-notification-component-xss-vulnerability
branch
September 13, 2022 15:39
n8n-assistant
bot
added
the
Upcoming Release
Will be part of the upcoming release
label
Sep 13, 2022
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
…e components (n8n-io#4081) * feat(editor): Implement HTML sanitization when using `dangerouslyUseHTMLString` option of Notification and Message components * 🐛 Implement mechanism to allow for A href actions from locale strings * 🐛 Prevent link action default * ♻️ Use `xss` library instead of `sanitize-html` to handle sanitization * 🔥 Remove `onLinkClick` functionality of `$showMessage`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N8N-4385