Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for unit testing using vitest in editor-ui #4184

Merged
merged 4 commits into from
Sep 28, 2022
Merged

feat: add support for unit testing using vitest in editor-ui #4184

merged 4 commits into from
Sep 28, 2022

Conversation

alexgrozav
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Sep 26, 2022

N8N-3378

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 26, 2022
netroy
netroy reviewed Sep 26, 2022
View reviewed changes
packages/editor-ui/tsconfig.json
@@ -10,11 +10,8 @@
"importHelpers": true,
"allowSyntheticDefaultImports": true,
"baseUrl": ".",
"typeRoots": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these even needed anymore?
I'm able to remove typeRoots and types, and still able to build and test everything in this package.

netroy
netroy reviewed Sep 26, 2022
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please update the package-lock.json once more? and remove type & typesRoot from editor-ui?

@alexgrozav
Copy link
Contributor Author

@netroy I've updated the tsconfig.json file to only include types. The vitest/globals types are still needed to add automatic global references in unit test files. The package-lock.json file has been updated as well.

netroy
netroy approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexgrozav alexgrozav merged commit bb66e60 into master Sep 28, 2022
@alexgrozav alexgrozav deleted the n8n-3378-add-vitest-configuration-to-design branch September 28, 2022 08:26
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 28, 2022
@janober
Copy link
Member

janober commented Sep 30, 2022

Got released with n8n@0.196.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Sep 30, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
@alexgrozav
feat: add support for unit testing using vitest in editor-ui (n8n-io#…
b3c2153 
…4184)

* feat: add support for unit testing using vitest in editor-ui

* fix(editor): update tsconfig types and typeRoots

* chore(editor): update package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgrozav @janober @netroy