refactor: make IPollFunctions emit consistent with trigger emit #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
|
LGTM from my side. @janober any objections on renaming |
krynble
previously approved these changes
Oct 5, 2022
…consistent-in-poll-functions
krynble
approved these changes
Nov 8, 2022
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 8, 2022
* master: fix(editor): Fix for incorrect execution saving indicator in executions view (#4547) feat(API): Report unhandled app crashes to Sentry (#4548) fix(SendInBlue Trigger Node): fix typo in credential name (#4357) refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ (#4523) refactor: make IPollFunctions emit consistent with trigger emit (#4201) feat: Add cypress e2e tests for signup and signin (#3490) fix(core): Fix manual execution of pinned trigger on main mode (#4535) fix(HTTP Request Node): Show error cause in the output (#4538) refactor(core): Skip interim updates check (no-changelog) (#4536) ci: Revert support for node.js 18 (#4518) (#4537) ci: Start supporting node.js 18 (#4518)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.