feat(editor): block UI in NDV when workflow is listening to events #4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
cstuncsik
changed the title
…listening button in input pane for webhook
…sibility-of-trigger-ndv
MiloradFilipovic
previously approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Looks good. I left some comments in the linear ticket that need to be addressed before merging.
…sibility-of-trigger-ndv
…sibility-of-trigger-ndv
…sibility-of-trigger-ndv # Conflicts: # packages/editor-ui/src/components/NodeDetailsView.vue # packages/editor-ui/src/components/NodeSettings.vue
…sibility-of-trigger-ndv
mutdmour
approved these changes
Oct 31, 2022
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
…8n-io#4390) * feature: block UI in NDV when workflow is listening to events * feature: hide stop listening button in parameters pane and show stop listening button in input pane for webhook * feature: create block UI design system component * fix: add back accidentally removed prop * fix(editor): extend node settings event listener button functionality * refactor(editor): using composition API in BlockUi component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.