Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(API): Set up error tracking using Sentry #4394

Merged
merged 24 commits into from
Nov 4, 2022
Merged

feat(API): Set up error tracking using Sentry #4394

merged 24 commits into from
Nov 4, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Oct 20, 2022 •
edited
Loading

PS: this does not include error tracking for self-hosted frontends and cli commands

@netroy netroy requested a review from csuermann October 20, 2022 15:34
@linear
Copy link

linear bot commented Oct 20, 2022

N8N-4727

@netroy netroy changed the title feat(cli): Setup error tracking using Sentry feat (cli): Setup error tracking using Sentry Oct 20, 2022
@netroy netroy changed the title feat (cli): Setup error tracking using Sentry feat(API): Setup error tracking using Sentry Oct 20, 2022
@netroy netroy changed the title feat(API): Setup error tracking using Sentry feat: Setup error tracking using Sentry Oct 20, 2022
@netroy netroy changed the title feat: Setup error tracking using Sentry feat(api): Setup error tracking using Sentry Oct 20, 2022
@netroy netroy changed the title feat(api): Setup error tracking using Sentry feat(API): setup error tracking using Sentry Oct 20, 2022
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 20, 2022
csuermann
csuermann reviewed Oct 20, 2022
View reviewed changes
Copy link
Contributor

@csuermann csuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this by default make all n8n user instances submit exceptions to our sentry?

@netroy
Copy link
Member Author

netroy commented Oct 20, 2022 •
edited
Loading

Will this by default make all n8n user instances submit exceptions to our sentry?

yes. but only if they have diagnostics enabled.
Also, the default DSN used here is different from the ones we'll be using on the cloud.

@netroy netroy marked this pull request as draft October 20, 2022 16:29
@netroy netroy force-pushed the N8N-4727-setup-sentry branch 2 times, most recently from b7d32d4 to 178c58c Compare October 27, 2022 13:32
@netroy netroy marked this pull request as ready for review October 27, 2022 13:34
@netroy netroy requested review from csuermann and RicardoE105 and removed request for csuermann October 27, 2022 13:40
RicardoE105
RicardoE105 previously approved these changes Oct 28, 2022
View reviewed changes
@netroy netroy mentioned this pull request Oct 28, 2022
Merged
ivov
ivov reviewed Oct 31, 2022
View reviewed changes
packages/cli/config/schema.ts Outdated Show resolved Hide resolved
packages/workflow/src/ErrorHandler.ts Outdated Show resolved Hide resolved
packages/workflow/src/utils.ts Outdated Show resolved Hide resolved
packages/cli/src/WorkflowExecuteAdditionalData.ts Outdated Show resolved Hide resolved
packages/cli/src/ErrorHandling.ts Outdated Show resolved Hide resolved
packages/cli/src/ErrorHandling.ts Outdated Show resolved Hide resolved
packages/cli/src/WebhookServer.ts Show resolved Hide resolved
packages/workflow/src/ErrorHandler.ts Outdated Show resolved Hide resolved
ivov
ivov reviewed Nov 2, 2022
View reviewed changes
packages/workflow/src/ErrorReporterProxy.ts Outdated Show resolved Hide resolved
packages/workflow/src/ErrorReporterProxy.ts Outdated Show resolved Hide resolved
packages/workflow/src/utils.ts Outdated Show resolved Hide resolved
packages/workflow/src/utils.ts Outdated Show resolved Hide resolved
packages/cli/src/WorkflowHelpers.ts Outdated Show resolved Hide resolved
packages/cli/src/LoadNodesAndCredentials.ts Show resolved Hide resolved
packages/cli/src/ResponseHelper.ts Show resolved Hide resolved
@netroy netroy requested a review from ivov November 2, 2022 15:46
ivov
ivov previously approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All comments are minor, feel free to disregard.

packages/cli/src/LoadNodesAndCredentials.ts Show resolved Hide resolved
packages/workflow/src/ErrorReporterProxy.ts Outdated Show resolved Hide resolved
packages/workflow/src/ErrorReporterProxy.ts Outdated Show resolved Hide resolved
packages/workflow/src/ErrorReporterProxy.ts Outdated Show resolved Hide resolved
packages/workflow/src/ErrorReporterProxy.ts Outdated Show resolved Hide resolved
@netroy netroy requested a review from ivov November 4, 2022 11:50
@ivov ivov changed the title feat(API): setup error tracking using Sentry feat(API): Set up error tracking using Sentry Nov 4, 2022
@netroy netroy merged commit 41cb0ee into master Nov 4, 2022
@netroy netroy deleted the N8N-4727-setup-sentry branch November 4, 2022 16:34
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 4, 2022
MiloradFilipovic added a commit that referenced this pull request Nov 7, 2022
@MiloradFilipovic
Merge branch 'master' into N8N-5191-pinia-migration-part2
f65d5a1 
* master:
  fix(editor): Showing string numbers and null properly in JSON view (#4513)
  fix(editor): Switch `CodeNodeEditor` linter parser to `esprima-next` (#4524)
  fix(API): Do not use names for typeorm connections (#4532)
  refactor(editor): Encapsulate canvas actions (#4416)
  fix: Database config should resolve entities and migrations folder relative to it's path (no-changelog) (#4527)
  feat(API): Set up error tracking using Sentry (#4394)
  fix(editor): Curb arg linting for `$input.first()` and `$input.last()` (#4526)
  fix(HTTP Request Node): use the data in "Put Output in Field" field (#4487)
  refactor: consolidate database configs (#4522)

# Conflicts:
#	packages/editor-ui/src/views/NodeView.vue
@netroy netroy mentioned this pull request Nov 8, 2022
Merged
@janober
Copy link
Member

janober commented Nov 10, 2022

Got released with n8n@0.202.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuermann csuermann csuermann left review comments

@ivov ivov ivov approved these changes

@RicardoE105 RicardoE105 RicardoE105 left review comments

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@netroy @janober @csuermann @RicardoE105 @ivov