fix(editor): Fix workflow back button navigation #4546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegIvaniv
added
ui
OlegIvaniv
deleted the
n8n-5247-fix-wf-save-changes-warning-routes-bug
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 9, 2022
* master: fix(editor): Fix workflow back button navigation (#4546) fix(Raindrop Node): Update access token URL (#4542) fix(editor): Fix workflow activation from the Workflows view (#4549) feat(core): Add ownership, sharing and credential details to `GET /workflows` (#4510) # Conflicts: # packages/editor-ui/src/views/SettingsCommunityNodesView.vue
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving and navigating away from a newly created workflow, we need to replace the
/workflow/newroute with the/workflow/$idso that when a user comes back, they land on the workflow itself. In order to do this, we have toreplacethe routes instead of pushing them.Also, when a user lands on the settings page, the sidebar button should take them to either the previous location, if there's one, or go to the workflows view. In order to do this, we need to store the
fromroute when accessing the Settings. For this, I had to refactor settings routing to use children routes and nested<router-view />. Doing this, we also have to moveprops: truefrom the FAKE_DOOR route to the SettingsView route and pass it as props in the component.CleanShot.2022-11-08.at.14.39.50-converted.mp4