Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add 'Stop execution' button to execution preview #4632

Merged
merged 5 commits into from
Nov 17, 2022

Conversation

MiloradFilipovic
Copy link
Contributor

This PR introduces a few visual changes to the preview for running executions:

  1. Stop execution button
  2. Execution timer in the executions sidebar (shows live timer for running executions),
  3. New spinner icon

SCR-20221117-f07

@MiloradFilipovic MiloradFilipovic self-assigned this Nov 17, 2022
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 17, 2022
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the following. No deep context so if any are intended, please disregard.

  1. Stopping a running execution triggers two toasts: error for Problem in node ‘On clicking 'execute'‘ Workflow-Execution has been canceled! (non-auto-dismissing) and success for Execution stopped. Execution ID X (auto-dismissing). I would think only the success toast is enough.
  2. Selecting a stopped execution from the executions view triggers Workflow-Execution has been canceled!. I would not expect to see this toast again when selecting an old execution.
  3. Retrying a stopped execution triggers Retry unsuccessful every time. The workflow is a simple Manual Trigger and Wait so it should be able to retry.
  4. Selecting a failed retry of a stopped execution triggers "Cannot read properties of undefined (reading 'node')"
  5. Setting up a lengthy execution and switching to Executions view auto-selects the last already completed execution, but I would expect the running execution to be auto-selected.
  6. Disabling nodes in Workflow view is broken, have not tested if coming from master. Edit: Disregard, this is on master.

@MiloradFilipovic
Copy link
Contributor Author

@ivov I would say this is all expected. Here's the reasoning:

1., 2. and 4. These popups were discussed when implementing this feature and we decided to keep all messages from the old execution preview. I just now talked with Max and the agreement is to remove the Failed execution messages that appear and pile up when opening failed executions. Also we agreed to be conservative with removing popups so we don't remove anything useful. Deleting mentioned popup will already clear a lot of clutter so I'll do this in next commit.

3. I don't have much context on this, but retrying stopped executions hasn't been possible in previous versions also (just tested 0.198.2). Will ask around to see why is this but for now would leave it out of scope for this particular PR.

5. Executions tab always remembers the last selected execution, so that one will be automatically opened when switching to it (or the first one if it's opened for the first time or remembered execution is not longer available).

Let me know if this all seems reasonable.

@MiloradFilipovic MiloradFilipovic merged commit be7672a into master Nov 17, 2022
@MiloradFilipovic MiloradFilipovic deleted the N8N-5245-stop-execution-from-preview branch November 17, 2022 16:34
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 17, 2022
@janober
Copy link
Member

janober commented Nov 17, 2022

Got released with n8n@0.203.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants