feat(editor): Node creator actions #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/editor-ui/src/components/Node/NodeCreator/CategorizedItems.vue
…ver globalLinkActions to composable
…to categorized items
… fix API actions display and prevent dragging of action nodes
…odes for the trigger helper panel, minor fixes
packages/design-system/src/components/N8nNodeCreatorNode/NodeCreatorNode.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/N8nNodeCreatorNode/NodeCreatorNode.vue
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/Node/NodeCreator/TriggerHelperPanel.vue
Outdated
Show resolved
Hide resolved
MiloradFilipovic
previously approved these changes
Dec 8, 2022
|
@MiloradFilipovic I goofed up and forgot to fix the breaking e2e tests. Should be all green now. Can you approve once more, please? |
MiloradFilipovic
previously approved these changes
Dec 8, 2022
…es added from trigger panel
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 9, 2022
* master: fix: Use license-sdk v1.6.1 (#4872) feat(editor): Node creator actions (#4696) test(editor): Set e2e test retries (#4870) fix: Increase workflow reactivation max timeout to 1 day (#4869) fix: Stop returning `UNKNOWN ERROR` in the response if an actual error message is available (#4859) fix: Issue listing executions with Postgres (#4856) test(editor): Fix flaky e2e tests (#4779) fix: Use the same entrypoint for custom docker images as for the other images (no-changelog) (#4849) refactor: Deprecate `alwaysOpenEditWindow` for `string` (#4839) fix: Upgrade sse-channel to mitigate CVE-2019-10744 (#4835) # Conflicts: # packages/editor-ui/src/App.vue # packages/editor-ui/src/views/NodeView.vue
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 9, 2022
* feature/undo-redo: ⚡ Fixing tracking new nodes after latest merge ⚡ Fixing undo for moving connections ⚡ Fixing recording when moving nodes fix: Use license-sdk v1.6.1 (#4872) feat(editor): Node creator actions (#4696) test(editor): Set e2e test retries (#4870) ⚡ Fix for not clearing redo stack on every user action fix: Increase workflow reactivation max timeout to 1 day (#4869) 👌 Implemented command comparing logic 👌 Moving undo logic for disabling nodes to `NodeView` 👌 Addressing PR comments part 1 fix: Stop returning `UNKNOWN ERROR` in the response if an actual error message is available (#4859) fix: Issue listing executions with Postgres (#4856) test(editor): Fix flaky e2e tests (#4779) fix: Use the same entrypoint for custom docker images as for the other images (no-changelog) (#4849) refactor: Deprecate `alwaysOpenEditWindow` for `string` (#4839) fix: Upgrade sse-channel to mitigate CVE-2019-10744 (#4835) # Conflicts: # cypress/e2e/7-workflow-actions.cy.ts # cypress/pages/workflow.ts
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements categorization and display of node actions. Actions are visible when accessed via the "On App Event" node creator item from the trigger helper panel.
After clicking the action, we add a node to the canvas with prefilled fields corresponding to the action config. Because we're merging regular/trigger nodes, if the added action is from the regular node, we also add a Manual trigger.
Part of this PR is also unifying the names of the node overrides as requested by the product/design.
Categorization
Actions are categorized into two categories.
Resource actions(regular nodes)
To get these categories, we iterate over the resource options property of a node and create a category for each property. We then look for operations that correspond to this resource. To map the operation to the resource, we use
displayOptionsproperty which indicates if the operation option is relevant to the resource.Recommended category(trigger nodes)
We check for the following properties in node config: 'event,' 'events,' and 'trigger on.' If any of these three exists, we take its options and parse them as recommended actions.
CleanShot.2022-11-30.at.15.32.01.mp4