Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove annonymous ID #5093

Merged
merged 1 commit into from
Jan 5, 2023
Merged

fix: Remove annonymous ID #5093

merged 1 commit into from
Jan 5, 2023

Conversation

krynble
Copy link
Contributor

@krynble krynble commented Jan 5, 2023

According to the RudderStack docs, only one of userId or annonymousId should be used. If annonymousId is provided then userId is ignored.

image

This is causing ingestion issues as reported in Slack.

Quoting the report: Events are getting rate-limited due to the device_id: 000000000000 issue and there are already 200k+ pending events accumulated. Inevitably, event delivery delays will be observed..

Suggested action: Customer Action: Include a proper device_id in events

@krynble krynble merged commit 11a46a4 into master Jan 5, 2023
@krynble krynble deleted the fix/telemetry-ingestion-issue branch January 5, 2023 13:59
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Jan 5, 2023
@janober janober added Upcoming Release Will be part of the upcoming release and removed Upcoming Release Will be part of the upcoming release labels Jan 5, 2023
@janober
Copy link
Member

janober commented Jan 5, 2023

Got released with n8n@0.210.1

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jan 5, 2023
MiloradFilipovic added a commit that referenced this pull request Jan 9, 2023
* master: (53 commits)
  fix: Remove anonymous ID from tracking calls (#5099)
  refactor(core): Add more overloads for string-type node parameters (no-changelog) (#5101)
  fix(Read Binary File Node): Do not crash the execution when the source file does not exist (#5100)
  fix: Stop OOM crashes in Execution Data pruning (#5095)
  feat(editor): Introduce proxy completions to expressions (#5075)
  fix(Google Sheets Node): Fix for auto-range detection
  📚 Update CHANGELOG.md and main package.json to 0.210.1
  🔖 Release n8n@0.210.1
  ⬆️ Set n8n-editor-ui@0.176.1 and n8n-nodes-base@0.208.1 on n8n
  🔖 Release n8n-editor-ui@0.176.1
  ⬆️ Set n8n-design-system@0.50.1 on n8n-editor-ui
  🔖 Release n8n-design-system@0.50.1
  🔖 Release n8n-nodes-base@0.208.1
  fix: Pass in the correct server reference to external hooks (no-changelog) (#5094)
  fix(Google Sheets Node): Append or Update fails for numeric values
  feat: Add user management invite links without SMTP set up (#5084)
  fix: Remove annonymous ID (no-changelog) (#5093)
  📚 Update CHANGELOG.md and main package.json to 0.210.0
  🔖 Release n8n@0.210.0
  ⬆️ Set n8n-core@0.150.0, n8n-editor-ui@0.176.0, n8n-nodes-base@0.208.0 and n8n-workflow@0.132.0 on n8n
  ...

# Conflicts:
#	packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants