Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New trigger PostgreSQL #5495

Merged
merged 40 commits into from
Jun 7, 2023
Merged

Conversation

agobrech
Copy link
Contributor

No description provided.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node labels Feb 16, 2023
@agobrech agobrech marked this pull request as ready for review February 21, 2023 14:40
@agobrech agobrech added the node/name Changes to the node display name label Feb 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Files matching packages/nodes-base/package.json:

  • Avoided adding dependencies for nodes if not absolutely necessary.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (e33989b) 28.31% compared to head (4b191a6) 28.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5495      +/-   ##
==========================================
- Coverage   28.31%   28.22%   -0.09%     
==========================================
  Files        2982     2984       +2     
  Lines      185169   185284     +115     
  Branches    20305    20326      +21     
==========================================
- Hits        52431    52300     -131     
- Misses     131951   132197     +246     
  Partials      787      787              
Impacted Files Coverage Δ
...s-base/nodes/Postgres/PostgresTrigger.functions.ts 0.00% <0.00%> (ø)
.../nodes-base/nodes/Postgres/PostgresTrigger.node.ts 0.00% <0.00%> (ø)
...s/nodes-base/nodes/Postgres/v1/genericFunctions.ts 19.74% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Jun 7, 2023

Passing run #1130 ↗︎

0 228 0 0 Flakiness 0

Details:

🌳 node-244-postgres-trigger-node 🖥️ browsers:node18.12.0-chrome107 🤖 agobrech...
Project: n8n Commit: 4b191a6cd7
Status: Passed Duration: 07:33 💡
Started: Jun 7, 2023 8:48 AM Ended: Jun 7, 2023 8:56 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

✅ All Cypress E2E specs passed

@agobrech agobrech merged commit 4488f93 into master Jun 7, 2023
@agobrech agobrech deleted the node-244-postgres-trigger-node branch June 7, 2023 09:01
MiloradFilipovic added a commit that referenced this pull request Jun 13, 2023
* master:
  test(editor): Unit test Version control frontend components (#6408)
  fix: Fist name to First Name in certain nodes (no-changelog) (#6404)
  fix(core): Allow all executions to be stopped (#6386)
  fix(core): RMC boolean value fix (#6397)
  fix(editor): Remove root level tag selector from css module to avoid making it a global style (#6392)
  fix(Ldap Node): Add DN field to update operation (#6371)
  feat: New trigger PostgreSQL  (#5495)
  build: Update pnpm lock file (no-changelog) (#6395)
  fix(Date & Time Node): Reset responseData at end of loop (#6385)
  refactor(core): Google service account remove duplicated functions (no-changelog) (#6368)
  refactor(LoneScale List Node)!: Rename to LoneScale (#6337)
  fix(editor): Update version control setup CTA tooltip (#6393)
  ci: Fix build (no-changelog) (#6391)
  fix(editor): Add button to refresh branches (#6387)
  fix(editor): Add Set up version control CTA (#6356)
  fix(editor): Remove explicit parameter name scanning for code editors (#6390)
  ci: Fix build (no-changelog) (#6379)
  fix(editor): Adding branch color (#6380)
  refactor(editor): Remove user activation modal (no-changelog) (#6361)
  feat(editor): Change upgrade CTA on community editions (no-changelog) (#6317)
@janober
Copy link
Member

janober commented Jun 14, 2023

Got released with n8n@0.232.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/name Changes to the node display name node/new Creation of an entirely new node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants