Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Initialize License and LDAP in the correct order #5673

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Mar 10, 2023

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 6.66% and project coverage change: -0.01 ⚠️

Comparison is base (5c4343b) 10.26% compared to head (068de92) 10.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5673      +/-   ##
==========================================
- Coverage   10.26%   10.26%   -0.01%     
==========================================
  Files        2201     2201              
  Lines       84647    84646       -1     
  Branches    16668    16668              
==========================================
- Hits         8686     8685       -1     
  Misses      75484    75484              
  Partials      477      477              
Impacted Files Coverage Δ
packages/cli/src/commands/BaseCommand.ts 33.33% <0.00%> (ø)
packages/cli/src/commands/start.ts 0.00% <0.00%> (ø)
packages/cli/src/Server.ts 14.67% <50.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 10, 2023
@netroy netroy merged commit 90afa5e into master Mar 10, 2023
@netroy netroy deleted the fix-ldap-init branch March 10, 2023 18:05
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 10, 2023
@janober
Copy link
Member

janober commented Mar 16, 2023

Got released with n8n@0.220.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants