Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add support for schema view in the NDV output #5688

Merged
merged 8 commits into from
Mar 16, 2023

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Mar 14, 2023

  • Enable the "Schema" format also in the output panel
  • Add e2e spec to test NDV output schema and some minor e2e tweaks
  • Fix classes naming in RunData component

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@cypress
Copy link

cypress bot commented Mar 14, 2023

Passing run #195 ↗︎

0 183 0 0 Flakiness 0

Details:

🌳 ado-286-add-schema-view-mode-to-ndv-output 🖥️ base:16.18.1 🤖 oleg 🗃️ e2e/*
Project: n8n Commit: 046949cb04
Status: Passed Duration: 06:04 💡
Started: Mar 15, 2023 10:50 AM Ended: Mar 15, 2023 10:56 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.01 🎉

Comparison is base (39c871d) 13.03% compared to head (e7041dc) 13.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5688      +/-   ##
==========================================
+ Coverage   13.03%   13.05%   +0.01%     
==========================================
  Files        2454     2462       +8     
  Lines      112599   112686      +87     
  Branches    17491    17498       +7     
==========================================
+ Hits        14679    14711      +32     
- Misses      97420    97475      +55     
  Partials      500      500              
Impacted Files Coverage Δ
packages/editor-ui/src/stores/nodeCreator.ts 16.12% <0.00%> (-0.09%) ⬇️
.../nodes-base/nodes/Metabase/QuestionsDescription.ts 0.00% <0.00%> (ø)
...s-base/nodes/SplitInBatches/SplitInBatches.node.ts 84.61% <100.00%> (+8.14%) ⬆️

... and 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@OlegIvaniv OlegIvaniv merged commit 541850f into master Mar 16, 2023
@OlegIvaniv OlegIvaniv deleted the ado-286-add-schema-view-mode-to-ndv-output branch March 16, 2023 09:19
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
@janober
Copy link
Member

janober commented Mar 16, 2023

Got released with n8n@0.220.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
)

* feat(editor): Add support for schema view in the NDV output

* Make intercepts waiting optional in waitForLoad method

* Update RunDataSchema snapshots

* Do not reset output panel view on execution, properly key run RunDataSchemaItem to make sure they are unique across panels

* Update snapshot tests

* Make adding of schema view button option more readable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants