-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Add support for schema view in the NDV output #5688
feat(editor): Add support for schema view in the NDV output #5688
Conversation
OlegIvaniv
commented
Mar 14, 2023
•
edited
Loading
edited
- Enable the "Schema" format also in the output panel
- Add e2e spec to test NDV output schema and some minor e2e tweaks
- Fix classes naming in RunData component
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Passing run #195 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5688 +/- ##
==========================================
+ Coverage 13.03% 13.05% +0.01%
==========================================
Files 2454 2462 +8
Lines 112599 112686 +87
Branches 17491 17498 +7
==========================================
+ Hits 14679 14711 +32
- Misses 97420 97475 +55
Partials 500 500
... and 18 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…SchemaItem to make sure they are unique across panels
Got released with |
) * feat(editor): Add support for schema view in the NDV output * Make intercepts waiting optional in waitForLoad method * Update RunDataSchema snapshots * Do not reset output panel view on execution, properly key run RunDataSchemaItem to make sure they are unique across panels * Update snapshot tests * Make adding of schema view button option more readable