Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipedrive OAuth2 Support #641

Merged
merged 5 commits into from
Jul 23, 2020
Merged

Pipedrive OAuth2 Support #641

merged 5 commits into from
Jul 23, 2020

Conversation

Rupenieks
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ RicardoE105
❌ Rupenieks


Rupenieks seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

},
{
name: 'httpBasicAuth',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed httpBasicAuth and none. If someone has selected those when update to the new version it would break the workflow. httpBasicAuth and none has to be here and pipedriveOAuth2Api has to be added.

@janober janober force-pushed the master branch 2 times, most recently from e4cdc72 to 941ee06 Compare July 12, 2020 10:17
@RicardoE105 RicardoE105 merged commit 61d7c52 into master Jul 23, 2020
@RicardoE105
Copy link
Contributor

@Rupenieks got merged.

@janober janober deleted the Pipedrive-OAuth2-support branch August 27, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants