Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Make it possible to activate inactive workflows #6759

Conversation

schroedan
Copy link
Contributor

Github issue / Community forum post (link here to close automatically): #4753

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@Joffcom
Copy link
Member

Joffcom commented Jul 27, 2023

Hey @schroedan,

Thanks for the PR, I have added a note to N8N-3763 to let the team know there is something to review.

@n8n-assistant n8n-assistant bot added community Authored by a community member core Enhancement outside /nodes-base and /editor-ui labels Jul 27, 2023
@schroedan schroedan force-pushed the N8N-3763-fix-update-workflow-command branch from 2c38559 to 30f3ae7 Compare July 27, 2023 12:24
@jayjayb772
Copy link

jayjayb772 commented Jul 28, 2023

I've been working with the n8n CLI the past few days and kept getting confused about why n8n update:workflow --id=$ID --active=true would output Deactivating workflow with ID:
I'm glad someone else noticed it too.

Thank you!!

@Jason-M-Spark
Copy link

Any update on this? I'd love for this to get fixed.

@despairblue
Copy link
Contributor

despairblue commented Jan 23, 2024

@schroedan I took your commits, rebased them and merged them in: #8412

This should be in the next release 🎉

Thanks for fixing this ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member core Enhancement outside /nodes-base and /editor-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants