Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix watch command in nodes-base (no-changelog) #6895

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Aug 9, 2023

To fix Cannot find module '@utils/utilities' on watch

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/nodes-base/package.json:

  • Avoided adding dependencies for nodes if not absolutely necessary.

Make sure to check off this list before asking for review.

netroy
netroy previously approved these changes Aug 9, 2023
@cypress
Copy link

cypress bot commented Aug 9, 2023

Passing run #1837 ↗︎

0 221 0 0 Flakiness 0

Details:

🌳 fix-watch-in-nodes-base 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 3842094c28
Status: Passed Duration: 08:22 💡
Started: Aug 9, 2023 3:36 PM Ended: Aug 9, 2023 3:44 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d396935) 24.83% compared to head (3842094) 24.83%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6895   +/-   ##
=======================================
  Coverage   24.83%   24.83%           
=======================================
  Files        3144     3144           
  Lines      191261   191257    -4     
  Branches    21086    21083    -3     
=======================================
  Hits        47502    47502           
+ Misses     142782   142778    -4     
  Partials      977      977           

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

✅ All Cypress E2E specs passed

@ivov ivov merged commit 734d27f into master Aug 9, 2023
23 checks passed
@ivov ivov deleted the fix-watch-in-nodes-base branch August 9, 2023 15:54
@janober
Copy link
Member

janober commented Aug 16, 2023

Got released with n8n@1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants