Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for parameter lag #6942

Merged
merged 5 commits into from
Aug 29, 2023
Merged

test: Add tests for parameter lag #6942

merged 5 commits into from
Aug 29, 2023

Conversation

mutdmour
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@mutdmour mutdmour changed the title test: Add tests for parameter leg test: Add tests for parameter lag Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (a4578d6) 32.10% compared to head (ad74483) 32.10%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6942      +/-   ##
==========================================
- Coverage   32.10%   32.10%   -0.01%     
==========================================
  Files        3186     3186              
  Lines      195760   195763       +3     
  Branches    21353    21351       -2     
==========================================
- Hits        62853    62851       -2     
- Misses     131873   131878       +5     
  Partials     1034     1034              
Files Changed Coverage Δ
packages/editor-ui/src/components/Node.vue 68.94% <100.00%> (ø)
packages/editor-ui/src/components/TriggerPanel.vue 53.94% <100.00%> (+0.30%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 16, 2023
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor suggestion

cypress/pages/workflow.ts Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Aug 16, 2023

2 flaky tests on run #2031 ↗︎

0 233 0 0 Flakiness 2

Details:

🌳 ado-974-e2e 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project: n8n Commit: ad74483c0f
Status: Passed Duration: 07:21 💡
Started: Aug 29, 2023 10:43 AM Ended: Aug 29, 2023 10:50 AM
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Output Screenshots Video
Flakiness  28-debug.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Debug > should be able to debug executions Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv self-requested a review August 29, 2023 10:37
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@mutdmour mutdmour merged commit e1922f7 into master Aug 29, 2023
18 checks passed
@mutdmour mutdmour deleted the ado-974-e2e branch August 29, 2023 12:00
@janober
Copy link
Member

janober commented Aug 31, 2023

Got released with n8n@1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants