-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add tests for parameter lag #6942
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6942 +/- ##
==========================================
- Coverage 32.10% 32.10% -0.01%
==========================================
Files 3186 3186
Lines 195760 195763 +3
Branches 21353 21351 -2
==========================================
- Hits 62853 62851 -2
- Misses 131873 131878 +5
Partials 1034 1034
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one minor suggestion
2 flaky tests on run #2031 ↗︎
Details:
24-ndv-paired-item.cy.ts • 1 flaky test
28-debug.cy.ts • 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
✅ All Cypress E2E specs passed |
✅ All Cypress E2E specs passed |
Got released with |
Github issue / Community forum post (link here to close automatically):