Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Skip resource mapper test causing timeouts (no-changelog) #7034

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Aug 28, 2023

Skipping until we have time to address it. Failing at least since early last week.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 28, 2023
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Aug 29, 2023

Passing run #2026 ↗︎

0 232 0 0 Flakiness 0

Details:

🌳 skip-resource-mapping-test-causing-timeouts 🖥️ browsers:node18.12.0-chrome10...
Project: n8n Commit: d1edb3dea5
Status: Passed Duration: 07:07 💡
Started: Aug 29, 2023 9:11 AM Ended: Aug 29, 2023 9:18 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 38579e5 into master Aug 29, 2023
17 checks passed
@netroy netroy deleted the skip-resource-mapping-test-causing-timeouts branch August 29, 2023 09:19
@janober
Copy link
Member

janober commented Aug 31, 2023

Got released with n8n@1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants