Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Implement soft-deletions for executions #7092

Merged
merged 44 commits into from
Sep 20, 2023
Merged

refactor(core): Implement soft-deletions for executions #7092

merged 44 commits into from
Sep 20, 2023

Commits on Sep 4, 2023

  1. refactor(core): Simplify executions and binary data pruning

    @netroy @ivov
    netroy authored and ivov committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    29f1d11 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pay-771-implement-soft-deletion

    @ivov
    ivov committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    f7206fd View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Merge branch 'master' into pay-771-implement-soft-deletion

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9c8efbc View commit details
    Browse the repository at this point in the history

  2. Remove test code from service

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    05e3fef View commit details
    Browse the repository at this point in the history

  3. Use time constants

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9dabbe8 View commit details
    Browse the repository at this point in the history

  4. Improve naming

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3f7de8e View commit details
    Browse the repository at this point in the history

  5. Use native typeorm soft deletion

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5583814 View commit details
    Browse the repository at this point in the history

  6. Improve naming

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f50108a View commit details
    Browse the repository at this point in the history

  7. Make batch size class field

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    85ac53a View commit details
    Browse the repository at this point in the history

  8. Cleanup

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    1d87e9e View commit details
    Browse the repository at this point in the history

  9. Remove unused method

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    dd16e45 View commit details
    Browse the repository at this point in the history

  10. Cleanup

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    619bff6 View commit details
    Browse the repository at this point in the history

  11. Filter out soft-deleted executions

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    8cace11 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into pay-771-implement-soft-deletion

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    1fea046 View commit details
    Browse the repository at this point in the history

  13. Add tests

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c4ffe6d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Improve test

    @ivov
    ivov committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    738eb1b View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Soft-delete in single pass

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    259fe75 View commit details
    Browse the repository at this point in the history

  2. Restore value

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f3f5b27 View commit details
    Browse the repository at this point in the history

  3. Restore from debug value

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    65d17cb View commit details
    Browse the repository at this point in the history

  4. Add clarifying comments

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    96ae7b4 View commit details
    Browse the repository at this point in the history

  5. Update tests

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    21040b5 View commit details
    Browse the repository at this point in the history

  6. Add clarifying comment

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    9a25301 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Speed up pruning if high volume

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    0e075c2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pay-771-implement-soft-deletion

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e8ccf05 View commit details
    Browse the repository at this point in the history

  3. Remove call from hook

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    2071c7f View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Make execution ID non-nullable

    @ivov
    ivov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    67e163f View commit details
    Browse the repository at this point in the history

  2. Merge master

    @ivov
    ivov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    9665da1 View commit details
    Browse the repository at this point in the history

  3. Readability improvements

    @ivov
    ivov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    12636dd View commit details
    Browse the repository at this point in the history

  4. Adjust types, followup to 67e163f

    @ivov
    ivov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    e5c8c72 View commit details
    Browse the repository at this point in the history

  5. Fix lint

    @ivov
    ivov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    b7062e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Merge master

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    3bf3430 View commit details
    Browse the repository at this point in the history

  2. Clear timers on shutdown

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    abe6d9d View commit details
    Browse the repository at this point in the history

  3. Set timers only on main instance

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    2682b3d View commit details
    Browse the repository at this point in the history

  4. Also for clearing timers

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    1c788fe View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Add logging, refactor for readability

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8823554 View commit details
    Browse the repository at this point in the history

  2. Ensure hard-deletion select includes soft-deleted rows

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a5def40 View commit details
    Browse the repository at this point in the history

  3. Switch info to debug

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    77955e4 View commit details
    Browse the repository at this point in the history

  4. Fix tests

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b930e3e View commit details
    Browse the repository at this point in the history

  5. Remove redundant checks for deletedAt being NULL 

    The column `deletedAt` is marked `@DeleteDateColumn()` so all reads
from the repository automatically add a `WHERE` clause checking
that the column `IS NULL`.
    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e91f3de View commit details
    Browse the repository at this point in the history

  6. Fix lint

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2c3704d View commit details
    Browse the repository at this point in the history

  7. Fix last test

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    215f58e View commit details
    Browse the repository at this point in the history

  8. More missing loggers in tests

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c33d164 View commit details
    Browse the repository at this point in the history

  9. Add logger to even more test

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    69764f7 View commit details
    Browse the repository at this point in the history

  10. Refactor logging for tests

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7c3e58d View commit details
    Browse the repository at this point in the history