Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Lazy-load express-openapi-validator to reduce initial memory spike (no-changelog) #7111

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Sep 5, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (0036a47) 31.90% compared to head (56e6cbf) 31.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7111      +/-   ##
==========================================
- Coverage   31.90%   31.90%   -0.01%     
==========================================
  Files        3268     3268              
  Lines      197657   197657              
  Branches    21528    21523       -5     
==========================================
- Hits        63058    63056       -2     
- Misses     133561   133563       +2     
  Partials     1038     1038              
Files Changed Coverage Δ
packages/cli/src/PublicApi/index.ts 85.96% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Sep 5, 2023

1 failed test on run #2102 ↗︎

1 237 0 0 Flakiness 0

Details:

🌳 lazy-load-express-openapi-validator 🖥️ browsers:node18.12.0-chrome107 🤖 net...
Project: n8n Commit: 56e6cbf63e
Status: Failed Duration: 08:24 💡
Started: Sep 5, 2023 12:30 PM Ended: Sep 5, 2023 12:39 PM
Failed  cypress/e2e/17-workflow-tags.cy.ts • 1 failed test

View Output Video

Test Artifacts
Workflow tags > should update a tag via modal Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@netroy netroy merged commit cc37a50 into master Sep 5, 2023
16 of 18 checks passed
@netroy netroy deleted the lazy-load-express-openapi-validator branch September 5, 2023 12:42
@janober
Copy link
Member

janober commented Sep 6, 2023

Got released with n8n@1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants