-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(editor): Update .round() function in NumberExtensions.ts for clarity #7150
Conversation
…rity As per: https://community.n8n.io/t/round-description-is-possibly-wrong/30382/2 We should probably specify when a whole number is used, and when it isn't.
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🙌🏻
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7150 +/- ##
==========================================
- Coverage 32.00% 31.99% -0.01%
==========================================
Files 3277 3277
Lines 197964 197964
Branches 21593 21589 -4
==========================================
- Hits 63349 63342 -7
- Misses 133554 133561 +7
Partials 1061 1061
☔ View full report in Codecov by Sentry. |
Passing run #2145 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
✅ All Cypress E2E specs passed |
Got released with |
As per the forum post, we should probably specify when a whole number is returned, and when it isn't.
Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/round-description-is-possibly-wrong/30382/