Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(editor): Update .round() function in NumberExtensions.ts for clarity #7150

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

greyliath
Copy link
Contributor

As per the forum post, we should probably specify when a whole number is returned, and when it isn't.

Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/round-description-is-possibly-wrong/30382/

@greyliath greyliath self-assigned this Sep 11, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🙌🏻

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (5c6cccd) 32.00% compared to head (e1dd6ff) 31.99%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7150      +/-   ##
==========================================
- Coverage   32.00%   31.99%   -0.01%     
==========================================
  Files        3277     3277              
  Lines      197964   197964              
  Branches    21593    21589       -4     
==========================================
- Hits        63349    63342       -7     
- Misses     133554   133561       +7     
  Partials     1061     1061              
Files Changed Coverage Δ
...ckages/workflow/src/Extensions/NumberExtensions.ts 96.15% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greyliath greyliath changed the title Docs(Editor): Update .round() function in NumberExtensions.ts for clarity docs(editor): Update .round() function in NumberExtensions.ts for clarity Sep 11, 2023
@cypress
Copy link

cypress bot commented Sep 11, 2023

Passing run #2145 ↗︎

0 238 0 0 Flakiness 0

Details:

🌳 update_round_function_in_editor 🖥️ browsers:node18.12.0-chrome107 🤖 greylia...
Project: n8n Commit: e1dd6ffcd6
Status: Passed Duration: 07:38 💡
Started: Sep 11, 2023 4:22 PM Ended: Sep 11, 2023 4:29 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 11, 2023
@Joffcom Joffcom merged commit b67a6fc into master Sep 12, 2023
53 of 54 checks passed
@Joffcom Joffcom deleted the update_round_function_in_editor branch September 12, 2023 08:24
@janober
Copy link
Member

janober commented Sep 14, 2023

Got released with n8n@1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants