Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Generalize binary data manager interface (no-changelog) #7164

Merged
merged 115 commits into from
Sep 22, 2023
Merged

refactor(core): Generalize binary data manager interface (no-changelog) #7164

merged 115 commits into from
Sep 22, 2023

Commits on Sep 4, 2023

  1. refactor(core): Simplify executions and binary data pruning

    @netroy @ivov
    netroy authored and ivov committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    29f1d11 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pay-771-implement-soft-deletion

    @ivov
    ivov committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    f7206fd View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Merge branch 'master' into pay-771-implement-soft-deletion

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9c8efbc View commit details
    Browse the repository at this point in the history

  2. Remove test code from service

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    05e3fef View commit details
    Browse the repository at this point in the history

  3. Use time constants

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9dabbe8 View commit details
    Browse the repository at this point in the history

  4. Improve naming

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3f7de8e View commit details
    Browse the repository at this point in the history

  5. Use native typeorm soft deletion

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5583814 View commit details
    Browse the repository at this point in the history

  6. Improve naming

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f50108a View commit details
    Browse the repository at this point in the history

  7. Make batch size class field

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    85ac53a View commit details
    Browse the repository at this point in the history

  8. Cleanup

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    1d87e9e View commit details
    Browse the repository at this point in the history

  9. Remove unused method

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    dd16e45 View commit details
    Browse the repository at this point in the history

  10. Cleanup

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    619bff6 View commit details
    Browse the repository at this point in the history

  11. Filter out soft-deleted executions

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    8cace11 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into pay-771-implement-soft-deletion

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    1fea046 View commit details
    Browse the repository at this point in the history

  13. Add tests

    @ivov
    ivov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c4ffe6d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Improve test

    @ivov
    ivov committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    738eb1b View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Soft-delete in single pass

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    259fe75 View commit details
    Browse the repository at this point in the history

  2. Restore value

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f3f5b27 View commit details
    Browse the repository at this point in the history

  3. Restore from debug value

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    65d17cb View commit details
    Browse the repository at this point in the history

  4. Add clarifying comments

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    96ae7b4 View commit details
    Browse the repository at this point in the history

  5. Update tests

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    21040b5 View commit details
    Browse the repository at this point in the history

  6. Add typedi to core

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    aa4d633 View commit details
    Browse the repository at this point in the history

  7. Update package.json

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    e54becb View commit details
    Browse the repository at this point in the history

  8. Turn BinaryDataManager into service

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    80e7258 View commit details
    Browse the repository at this point in the history

  9. Add object to binary data schema options

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    3a8960f View commit details
    Browse the repository at this point in the history

  10. Use service throughout core and cli

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    64b1a96 View commit details
    Browse the repository at this point in the history

  11. Update tests

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f974b55 View commit details
    Browse the repository at this point in the history

  12. Reduce diff

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    36d0243 View commit details
    Browse the repository at this point in the history

  13. Update default

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    5e209e9 View commit details
    Browse the repository at this point in the history

  14. Add docline

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    0c3a6aa View commit details
    Browse the repository at this point in the history

  15. Remove redundant output types

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    3d4beba View commit details
    Browse the repository at this point in the history

  16. Remove unused type

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    1bf7a3d View commit details
    Browse the repository at this point in the history

  17. Rename to submanagers to client

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    1152092 View commit details
    Browse the repository at this point in the history

  18. Rename BinaryDataFileSystem to FileSystemClient

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    5627b4c View commit details
    Browse the repository at this point in the history

  19. Clean up types

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    6451750 View commit details
    Browse the repository at this point in the history

  20. Move binaryToBuffer to manager

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7a7ad54 View commit details
    Browse the repository at this point in the history

  21. Rename BinaryDataManager to BinaryDataService

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    cdfe2fc View commit details
    Browse the repository at this point in the history

  22. Unify storage path naming

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    b5bc390 View commit details
    Browse the repository at this point in the history

  23. Set binary data service in nodes-base test helper

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    c876697 View commit details
    Browse the repository at this point in the history

  24. Rename manager in nodes-base

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    25a796c View commit details
    Browse the repository at this point in the history

  25. More renamings

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    538d318 View commit details
    Browse the repository at this point in the history

  26. Generalize interface

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    c7cf4b1 View commit details
    Browse the repository at this point in the history

  27. Continue generalizing

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    307bb1b View commit details
    Browse the repository at this point in the history

  28. Fix test

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a2528d7 View commit details
    Browse the repository at this point in the history

  29. Better naming

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d0cd85e View commit details
    Browse the repository at this point in the history

  30. More renamings

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    bfdbdf5 View commit details
    Browse the repository at this point in the history

  31. Minor cleanup

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    25e80b9 View commit details
    Browse the repository at this point in the history

  32. More minor cleanup

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    3476f6c View commit details
    Browse the repository at this point in the history

  33. Add clarifying comment

    @ivov
    ivov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    9a25301 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Speed up pruning if high volume

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    0e075c2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pay-771-implement-soft-deletion

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e8ccf05 View commit details
    Browse the repository at this point in the history

  3. Remove call from hook

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    2071c7f View commit details
    Browse the repository at this point in the history

  4. Merge parent branch

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    be44721 View commit details
    Browse the repository at this point in the history

  5. Refix conflict

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1d50b61 View commit details
    Browse the repository at this point in the history

  6. Add formats to schema

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e042e91 View commit details
    Browse the repository at this point in the history

  7. Add ensureStringArray util

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e948f8f View commit details
    Browse the repository at this point in the history

  8. Adjust types based on parsing

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    0feb926 View commit details
    Browse the repository at this point in the history

  9. Add type guard

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    c73f18c View commit details
    Browse the repository at this point in the history

  10. Clean up types in init()

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    f8fec92 View commit details
    Browse the repository at this point in the history

  11. Fix test

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    93ea57c View commit details
    Browse the repository at this point in the history

  12. Remove unneeded modifier

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    c8676be View commit details
    Browse the repository at this point in the history

  13. Cleanup

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    25006e8 View commit details
    Browse the repository at this point in the history

  14. Fix node tests

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    a7156f8 View commit details
    Browse the repository at this point in the history

  15. Remove unneeded line

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e0e90b6 View commit details
    Browse the repository at this point in the history

  16. Rename constant

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    219addb View commit details
    Browse the repository at this point in the history

  17. Remove comment

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    d7c7f5f View commit details
    Browse the repository at this point in the history

  18. Fix tests

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1ea380d View commit details
    Browse the repository at this point in the history

  19. Cleanup

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    a5b388b View commit details
    Browse the repository at this point in the history

  20. Rename error

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9204754 View commit details
    Browse the repository at this point in the history

  21. Improve error message

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9597508 View commit details
    Browse the repository at this point in the history

  22. Better error

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    8fde8be View commit details
    Browse the repository at this point in the history

  23. Better message

    @ivov
    ivov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    ada012e View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Make execution ID non-nullable

    @ivov
    ivov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    67e163f View commit details
    Browse the repository at this point in the history

  2. Merge master

    @ivov
    ivov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    9665da1 View commit details
    Browse the repository at this point in the history

  3. Readability improvements

    @ivov
    ivov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    12636dd View commit details
    Browse the repository at this point in the history

  4. Adjust types, followup to 67e163f

    @ivov
    ivov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    e5c8c72 View commit details
    Browse the repository at this point in the history

  5. Merge parent branch

    @ivov
    ivov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    8849007 View commit details
    Browse the repository at this point in the history

  6. Fix lint

    @ivov
    ivov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    b7062e5 View commit details
    Browse the repository at this point in the history

  7. Fix lint

    @ivov
    ivov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    79ecaa9 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Cleanup

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    02b6d86 View commit details
    Browse the repository at this point in the history

  2. Comment out cache keys

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    96ea9ea View commit details
    Browse the repository at this point in the history

  3. Revert "Comment out cache keys" 

    This reverts commit 96ea9ea.
    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    3d76b21 View commit details
    Browse the repository at this point in the history

  4. Rename dir to TempBinaryData

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    455c327 View commit details
    Browse the repository at this point in the history

  5. Rename back to BinaryData

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    65b4fb0 View commit details
    Browse the repository at this point in the history

  6. Merge master

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    3bf3430 View commit details
    Browse the repository at this point in the history

  7. Clear timers on shutdown

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    abe6d9d View commit details
    Browse the repository at this point in the history

  8. Set timers only on main instance

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    2682b3d View commit details
    Browse the repository at this point in the history

  9. Also for clearing timers

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    1c788fe View commit details
    Browse the repository at this point in the history

  10. Merge parent branch

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    f248982 View commit details
    Browse the repository at this point in the history

  11. Rename back to localStoragePath

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    04f4b83 View commit details
    Browse the repository at this point in the history

  12. Remove unused arg

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    03264f9 View commit details
    Browse the repository at this point in the history

  13. Fix lint

    @ivov
    ivov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    a6e33d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Add logging, refactor for readability

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8823554 View commit details
    Browse the repository at this point in the history

  2. Ensure hard-deletion select includes soft-deleted rows

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a5def40 View commit details
    Browse the repository at this point in the history

  3. Switch info to debug

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    77955e4 View commit details
    Browse the repository at this point in the history

  4. Fix tests

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b930e3e View commit details
    Browse the repository at this point in the history

  5. Remove redundant checks for deletedAt being NULL 

    The column `deletedAt` is marked `@DeleteDateColumn()` so all reads
from the repository automatically add a `WHERE` clause checking
that the column `IS NULL`.
    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e91f3de View commit details
    Browse the repository at this point in the history

  6. Fix lint

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2c3704d View commit details
    Browse the repository at this point in the history

  7. Fix last test

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    215f58e View commit details
    Browse the repository at this point in the history

  8. More missing loggers in tests

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c33d164 View commit details
    Browse the repository at this point in the history

  9. Add logger to even more test

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    69764f7 View commit details
    Browse the repository at this point in the history

  10. Refactor logging for tests

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7c3e58d View commit details
    Browse the repository at this point in the history

  11. Merge parent branch

    @ivov
    ivov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    6fe79b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Merge master, fix conflicts

    @ivov
    ivov committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    4f025b2 View commit details
    Browse the repository at this point in the history

  2. Fix misresolved conflict

    @ivov
    ivov committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    80a4fc5 View commit details
    Browse the repository at this point in the history

  3. Remove excess check on init

    @ivov
    ivov committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    20d5ea7 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Remove ObjectStore.manager.ts stub

    @ivov
    ivov committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0f84eb6 View commit details
    Browse the repository at this point in the history

  2. Revert rename to BinaryDataManager

    @ivov
    ivov committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    605d02b View commit details
    Browse the repository at this point in the history

  3. Missing renaming in test

    @ivov
    ivov committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    c430f22 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Rename constant

    @ivov
    ivov committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    0cdfb79 View commit details
    Browse the repository at this point in the history

  2. Merge master

    @ivov
    ivov committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    08ce3f7 View commit details
    Browse the repository at this point in the history

  3. Restore LogCatch 

    `LogCatch` was merged into master at a different file: `/packages/core/binaryData/index.ts`, which is now at `BinaryData.service.ts`
    @ivov
    ivov committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    61c2f5a View commit details
    Browse the repository at this point in the history

  4. Add file not found error to getSize

    @ivov
    ivov committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    74adb24 View commit details
    Browse the repository at this point in the history

  5. Add mode to InvalidBinaryDataManagerError

    @ivov
    ivov committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    0bc2457 View commit details
    Browse the repository at this point in the history

  6. Delete many by execution IDs only if manager available

    @ivov
    ivov committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d27e4c4 View commit details
    Browse the repository at this point in the history