-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): Convert dynamic node-parameter routes to a decorated controller (no-changelog) #7284
Merged
Merged
refactor(core): Convert dynamic node-parameter routes to a decorated controller (no-changelog) #7284
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 changes: 120 additions & 0 deletions
120
packages/cli/src/controllers/dynamicNodeParameters.controller.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| import { Service } from 'typedi'; | ||
| import type { RequestHandler } from 'express'; | ||
| import { NextFunction, Response } from 'express'; | ||
| import type { | ||
| INodeListSearchResult, | ||
| INodePropertyOptions, | ||
| ResourceMapperFields, | ||
| } from 'n8n-workflow'; | ||
| import { jsonParse } from 'n8n-workflow'; | ||
|
|
||
| import { Authorized, Get, Middleware, RestController } from '@/decorators'; | ||
| import { getBase } from '@/WorkflowExecuteAdditionalData'; | ||
| import { DynamicNodeParametersService } from '@/services/dynamicNodeParameters.service'; | ||
| import { DynamicNodeParametersRequest } from '@/requests'; | ||
| import { BadRequestError } from '@/ResponseHelper'; | ||
|
|
||
| const assertMethodName: RequestHandler = (req, res, next) => { | ||
| const { methodName } = req.query as DynamicNodeParametersRequest.BaseRequest['query']; | ||
| if (!methodName) { | ||
| throw new BadRequestError('Parameter methodName is required.'); | ||
| } | ||
| next(); | ||
| }; | ||
|
|
||
| @Service() | ||
| @Authorized() | ||
| @RestController('/dynamic-node-parameters') | ||
| export class DynamicNodeParametersController { | ||
| constructor(private readonly service: DynamicNodeParametersService) {} | ||
|
|
||
| @Middleware() | ||
| parseQueryParams( | ||
| req: DynamicNodeParametersRequest.BaseRequest, | ||
| res: Response, | ||
| next: NextFunction, | ||
| ) { | ||
| const { credentials, currentNodeParameters, nodeTypeAndVersion } = req.query; | ||
| if (!nodeTypeAndVersion) { | ||
| throw new BadRequestError('Parameter nodeTypeAndVersion is required.'); | ||
| } | ||
| if (!currentNodeParameters) { | ||
| throw new BadRequestError('Parameter currentNodeParameters is required.'); | ||
| } | ||
|
|
||
| req.params = { | ||
| nodeTypeAndVersion: jsonParse(nodeTypeAndVersion), | ||
| currentNodeParameters: jsonParse(currentNodeParameters), | ||
| credentials: credentials ? jsonParse(credentials) : undefined, | ||
| }; | ||
|
|
||
| next(); | ||
| } | ||
|
|
||
| /** Returns parameter values which normally get loaded from an external API or get generated dynamically */ | ||
| @Get('/options') | ||
| async getOptions(req: DynamicNodeParametersRequest.Options): Promise<INodePropertyOptions[]> { | ||
| const { path, methodName, loadOptions } = req.query; | ||
| const { credentials, currentNodeParameters, nodeTypeAndVersion } = req.params; | ||
| const additionalData = await getBase(req.user.id, currentNodeParameters); | ||
|
|
||
| if (methodName) { | ||
| return this.service.getOptionsViaMethodName( | ||
| methodName, | ||
| path, | ||
| additionalData, | ||
| nodeTypeAndVersion, | ||
| currentNodeParameters, | ||
| credentials, | ||
| ); | ||
| } | ||
|
|
||
| if (loadOptions) { | ||
| return this.service.getOptionsViaLoadOptions( | ||
| jsonParse(loadOptions), | ||
| additionalData, | ||
| nodeTypeAndVersion, | ||
| currentNodeParameters, | ||
| credentials, | ||
| ); | ||
| } | ||
|
|
||
| return []; | ||
| } | ||
|
|
||
| @Get('/resource-locator-results', { middlewares: [assertMethodName] }) | ||
| async getResourceLocatorResults( | ||
| req: DynamicNodeParametersRequest.ResourceLocatorResults, | ||
| ): Promise<INodeListSearchResult | undefined> { | ||
| const { path, methodName, filter, paginationToken } = req.query; | ||
| const { credentials, currentNodeParameters, nodeTypeAndVersion } = req.params; | ||
| const additionalData = await getBase(req.user.id, currentNodeParameters); | ||
| return this.service.getResourceLocatorResults( | ||
| methodName, | ||
| path, | ||
| additionalData, | ||
| nodeTypeAndVersion, | ||
| currentNodeParameters, | ||
| credentials, | ||
| filter, | ||
| paginationToken, | ||
| ); | ||
| } | ||
|
|
||
| @Get('/resource-mapper-fields', { middlewares: [assertMethodName] }) | ||
| async getResourceMappingFields( | ||
| req: DynamicNodeParametersRequest.ResourceMapperFields, | ||
| ): Promise<ResourceMapperFields | undefined> { | ||
| const { path, methodName } = req.query; | ||
| const { credentials, currentNodeParameters, nodeTypeAndVersion } = req.params; | ||
| const additionalData = await getBase(req.user.id, currentNodeParameters); | ||
| return this.service.getResourceMappingFields( | ||
| methodName, | ||
| path, | ||
| additionalData, | ||
| nodeTypeAndVersion, | ||
| currentNodeParameters, | ||
| credentials, | ||
| ); | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to change now, just to consider - it might be more consistent to have
@RestController('/dynamic-node-parameters', { middlewares: [fn] })for controller-level middlewares, similar to endpoint-level middlewares.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's how we started with, but then the middleware functions could not use the injected dependencies, as the method being passed needed to exist before the class was instantiated.