Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): Add tests for endless execution issue #7420

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Oct 12, 2023

The first test ("itemless case") was originally added here but likely removed on accident.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b203665) 33.50% compared to head (d84eaae) 33.50%.

Additional details and impacted files
@@                                   Coverage Diff                                   @@
##           help-353-endless-executions-for-cloud-user-rentslam    #7420      +/-   ##
=======================================================================================
- Coverage                                                33.50%   33.50%   -0.01%     
=======================================================================================
  Files                                                     3389     3389              
  Lines                                                   207020   207020              
  Branches                                                 22339    22338       -1     
=======================================================================================
- Hits                                                     69366    69359       -7     
- Misses                                                  136533   136540       +7     
  Partials                                                  1121     1121              

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krynble krynble merged commit e2af7ef into help-353-endless-executions-for-cloud-user-rentslam Oct 12, 2023
8 checks passed
@krynble krynble deleted the add-tests-for-endless-execution-issue branch October 12, 2023 14:15
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants