Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): Add test for suppressing error on non-existing filepath (no-changelog) #7421

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Oct 12, 2023

Follow-up to #7411

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7703904) 33.50% compared to head (dfcdd55) 33.50%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7421      +/-   ##
==========================================
- Coverage   33.50%   33.50%   -0.01%     
==========================================
  Files        3389     3389              
  Lines      207036   207036              
  Branches    22346    22338       -8     
==========================================
- Hits        69377    69363      -14     
- Misses     136538   136552      +14     
  Partials     1121     1121              

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 13, 2023

Passing run #2490 ↗︎

0 251 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: dfcdd55434
Status: Passed Duration: 07:59 💡
Started: Oct 13, 2023 9:38 AM Ended: Oct 13, 2023 9:46 AM

Review all test suite changes for PR #7421 ↗︎

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 609f083 into master Oct 13, 2023
55 checks passed
@ivov ivov deleted the followup-to-7411 branch October 13, 2023 09:52
@janober
Copy link
Member

janober commented Oct 18, 2023

Got released with n8n@1.12.0

elsmr pushed a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants