Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Convert to/from binary data Node): Change Mime to MIME (no-changelog) #7446

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

StarfallProjects
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (57c6093) 33.50% compared to head (182eb06) 33.50%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7446      +/-   ##
==========================================
- Coverage   33.50%   33.50%   -0.01%     
==========================================
  Files        3390     3390              
  Lines      207082   207084       +2     
  Branches    22351    22347       -4     
==========================================
- Hits        69386    69385       -1     
- Misses     136573   136576       +3     
  Partials     1123     1123              
Files Coverage Δ
...s-base/nodes/MoveBinaryData/MoveBinaryData.node.ts 84.09% <ø> (ø)
...odes/Google/Calendar/GoogleCalendarTrigger.node.ts 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 16, 2023

1 flaky test on run #2502 ↗︎

0 253 0 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 StarfallProjects 🗃️ e2e/*
Project: n8n Commit: 182eb067e6
Status: Passed Duration: 08:52 💡
Started: Oct 16, 2023 1:36 PM Ended: Oct 16, 2023 1:44 PM
Flakiness  cypress/e2e/24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Output Screenshots Video

Review all test suite changes for PR #7446 ↗︎

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 869b8f1 into master Oct 16, 2023
54 of 55 checks passed
@Joffcom Joffcom deleted the mime-type branch October 16, 2023 15:54
@janober
Copy link
Member

janober commented Oct 18, 2023

Got released with n8n@1.12.0

elsmr pushed a commit that referenced this pull request Oct 19, 2023
…log) (#7446)

Github issue / Community forum post (link here to close automatically):
netroy pushed a commit that referenced this pull request Oct 23, 2023
…log) (#7446)

Github issue / Community forum post (link here to close automatically):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants