Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Customer.io Node): Fix api endpoint when using EU region #7485

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix(Customer.io Node): Fix api endpoint when using EU region #7485

merged 1 commit into from
Oct 23, 2023

Conversation

martinezleoml
Copy link
Contributor

Fixes #7484

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Oct 20, 2023
@Joffcom Joffcom changed the title fix(customer.io): target EU endpoint when needed for App API calls fix(Customer.io Node): Fix api endpoint when using EU region Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (76c0481) 33.55% compared to head (e87e95d) 33.55%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7485      +/-   ##
==========================================
- Coverage   33.55%   33.55%   -0.01%     
==========================================
  Files        3398     3398              
  Lines      207582   207585       +3     
  Branches    22425    22420       -5     
==========================================
- Hits        69652    69650       -2     
- Misses     136808   136813       +5     
  Partials     1122     1122
Files Coverage Δ
...es/nodes-base/nodes/CustomerIo/GenericFunctions.ts 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Joffcom
Copy link
Member

Joffcom commented Oct 23, 2023

Hey @martinezleoml,

Thanks for the PR, It looks good to me and is about to be merged so that it can be available in a future release.

@Joffcom Joffcom merged commit 519680c into n8n-io:master Oct 23, 2023
11 checks passed
netroy pushed a commit that referenced this pull request Oct 23, 2023
@martinezleoml @netroy
fix(Customer.io Node): Fix api endpoint when using EU region (#7485)
ea1b503 
Fixes #7484
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
netroy added a commit that referenced this pull request Oct 23, 2023
@github-actions @netroy
🚀 Release 1.12.1 (#7493)
2e79f64 
## [1.12.1](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.12.1)
(2023-10-23)


### Bug Fixes

* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465](#7465))
([4a1f4da](4a1f4da))
* **core:** Handle gzip and deflate compressed request payloads
([#7461](#7461))
([75981fb](75981fb))
* **core:** Reduce logging overhead for levels that do not output
([#7479](#7479))
([4a1641d](4a1641d))
* **Customer.io Node:** Fix api endpoint when using EU region
([#7485](#7485))
([ea1b503](ea1b503)),
closes [#7484](#7484)
* **editor:** Allow importing the same workflow multiple times
([#7458](#7458))
([15e1737](15e1737)),
closes [#7457](#7457)
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466](#7466))
([d84c367](d84c367))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483](#7483))
([368e3ee](368e3ee))
* **Google Sheets Node:** Append or update runs forever when without
column headers ([#7463](#7463))
([0d52490](0d52490))
* **MySQL Node:** Resolve expressions in v1
([#7464](#7464))
([70a10a9](70a10a9))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Oct 23, 2023

Got released with n8n@1.12.1

@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Merged
netroy added a commit that referenced this pull request Oct 25, 2023
@github-actions @netroy
🚀 Release 1.13.0 (#7512)
2987587 
# [1.13.0](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.13.0)
(2023-10-25)


### Bug Fixes

* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465](#7465))
([55c6a1b](55c6a1b))
* **core:** Ensure nodes post-processors run in the correct order
([#7500](#7500))
([6f45298](6f45298))
* **core:** Fix `frontend.settings` external hook execution
([#7496](#7496))
([774fe20](774fe20))
* **core:** Handle gzip and deflate compressed request payloads
([#7461](#7461))
([83762e0](83762e0))
* **core:** Reduce logging overhead for levels that do not output
([#7479](#7479))
([76c0481](76c0481))
* **Customer.io Node:** Fix api endpoint when using EU region
([#7485](#7485))
([519680c](519680c))
* **editor:** Allow importing the same workflow multiple times
([#7458](#7458))
([3c0a166](3c0a166))
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466](#7466))
([bc47365](bc47365))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483](#7483))
([450e0cc](450e0cc))
* **Google Sheets Node:** Append or update runs forever when without
column headers ([#7463](#7463))
([ab6a9bb](ab6a9bb))
* **Microsoft SQL Node:** Prevent SQL injection
([#7467](#7467))
([a739245](a739245))
* **MQTT Trigger Node:** Fix node causing a start up hang when active
([#7498](#7498))
([baecb93](baecb93))
* **MySQL Node:** Resolve expressions in v1
([#7464](#7464))
([5c46bb0](5c46bb0))
* **Redis Node:** Fix adding sets data types
([#7444](#7444))
([4e66023](4e66023))
* **Spreadsheet File Node:** Fix include empty cells not working with v2
([#7505](#7505))
([05e6f2a](05e6f2a))


### Features

* **core:** Add support for oauth based service accounts with UM SMTP
([#7311](#7311))
([647372b](647372b))
* **editor:** Add PH tracking to event
([#7511](#7511))
([c47d27d](c47d27d))
* **Facebook Lead Ads Trigger Node:** Add Facebook Lead Ads Trigger Node
([#7113](#7113))
([ac814a9](ac814a9))
* **Ghost Node:** Add support for lexical format
([#7488](#7488))
([7b1973c](7b1973c))
* **RSS Feed Trigger Node:** Add RSS feed trigger node
([#7386](#7386))
([689360e](689360e))

Co-authored-by: netroy <netroy@users.noreply.github.com>
MiloradFilipovic added a commit that referenced this pull request Oct 25, 2023
@MiloradFilipovic
Merge branch 'master' into debug-canvas-selection
57c8f2a 
* master: (30 commits)
  🚀 Release 1.14.0 (#7514)
  ci: Fix oclif manifest generation
  feat(Switch Node): Add support for infinite Switch outputs (#7499)
  🚀 Release 1.13.0 (#7512)
  fix(core): Ensure nodes post-processors run in the correct order (#7500)
  feat(editor): Add PH tracking to event (#7511)
  fix(core): Fix workflow activation with history and workflow history for EE (no-changelog) (#7508)
  refactor(core): Make executions pruning more resilient (#7480)
  fix(Spreadsheet File Node): Fix include empty cells not working with v2 (#7505)
  fix(core): Create instance settings directory recursively (no-changelog) (#7506)
  fix(Microsoft SQL Node): Prevent SQL injection (#7467)
  refactor(core): Make pruning via lifecycle configuration in S3 mode mandatory (#7482)
  fix(core): Always derive `instanceId` from the encryption key (no-changlog) (#7501)
  fix(MQTT Trigger Node): Fix node causing a start up hang when active (#7498)
  feat: Collect usage metrics on license renewal (no-changelog) (#7486)
  fix(core): Fix `frontend.settings` external hook execution (#7496)
  fix(Redis Node): Fix adding sets data types (#7444)
  fix: Save new version of the workflow instead of the previous (no-changelog) (#7428)
  refactor(core): Abstract away InstanceSettings and `encryptionKey` into injectable services (no-changelog) (#7471)
  fix(Customer.io Node): Fix api endpoint when using EU region (#7485)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
community Authored by a community member node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customer.io API calls fail on workspaces located in EU region
4 participants
@martinezleoml @CLAassistant @Joffcom @janober